New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript example update #1471

Merged
merged 11 commits into from Dec 27, 2017

Conversation

Projects
None yet
3 participants
@rosskevin
Copy link
Collaborator

rosskevin commented Dec 27, 2017

Working on upgrading the typescript example to use the lates apollo-codegen with typescript-modern and the Query render callback component.

I have tried to use src/ direct from the example and have fixed various type usage issues found in the source, though should be no runtime changes. This is going to need to be handled bit by bit to get it updated and running.

@meteor-bot

This comment has been minimized.

Copy link

meteor-bot commented Dec 27, 2017

Warnings
⚠️

❗️ Big PR

Generated by 🚫 dangerJS

@rosskevin

This comment has been minimized.

Copy link
Collaborator Author

rosskevin commented Dec 27, 2017

I'm actually not sure what is left here - as the relative imports don't work and we need them. The goal here is to get this dir to work with https://codesandbox.io

@rosskevin rosskevin force-pushed the rosskevin:examples-update branch from 8c3f8e6 to 45db2bd Dec 27, 2017

@rosskevin rosskevin merged commit 8f339f1 into apollographql:master Dec 27, 2017

4 checks passed

CLA Author has signed the Meteor CLA.
Details
bundlesize ./lib/umd/react-apollo.js: 4.66KB < maxSize 4.7KB gzip (10B larger than master, careful!)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.2%) to 96.219%
Details

@rosskevin rosskevin deleted the rosskevin:examples-update branch Dec 27, 2017

@rohmanhm

This comment has been minimized.

Copy link

rohmanhm commented Jan 8, 2018

Hi, thanks for the great example.
Is it already done?

I found this line trying to import Query and QueryResult from react-apollo which do not exist on typescript definition from react-apollo

import { Query, QueryResult } from 'react-apollo';

Is it really works? Can you explain more? I got confused right now.

@rosskevin

This comment has been minimized.

Copy link
Collaborator Author

rosskevin commented Jan 8, 2018

The example is not done and those components are only on master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment