New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed the variables from the render prop result in the Query. #1497

Merged
merged 3 commits into from Dec 30, 2017

Conversation

Projects
None yet
2 participants
@excitement-engineer
Copy link
Collaborator

excitement-engineer commented Dec 30, 2017

This PR removes the variables field in the result of the render prop in the Query component. The variable is already passed in the props of the component therefore there is no need to pass it in the render function.

@excitement-engineer excitement-engineer merged commit 177ccad into apollographql:master Dec 30, 2017

4 checks passed

CLA Author has signed the Meteor CLA.
Details
bundlesize ./lib/umd/react-apollo.js: 4.67KB < maxSize 4.7KB gzip (3B larger than master, careful!)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 96.181%
Details

@excitement-engineer excitement-engineer deleted the excitement-engineer:remove-variables-query-render branch Dec 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment