Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upRemoved the variables from the render prop result in the Query. #1497
Conversation
rosskevin
approved these changes
Dec 30, 2017
excitement-engineer
added some commits
Dec 30, 2017
excitement-engineer
merged commit 177ccad
into
apollographql:master
Dec 30, 2017
4 checks passed
excitement-engineer
deleted the
excitement-engineer:remove-variables-query-render
branch
Dec 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
excitement-engineer commentedDec 30, 2017
This PR removes the
variablesfield in the result of the render prop in theQuerycomponent. The variable is already passed in the props of the component therefore there is no need to pass it in the render function.