New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The mocks now take into account the specific variables used. Fixes #1412 #1501

Merged
merged 5 commits into from Jan 4, 2018

Conversation

Projects
None yet
3 participants
@excitement-engineer
Copy link
Collaborator

excitement-engineer commented Dec 31, 2017

Fixes #1412.

Note, after updating the code to fix the bug some of the tests broke. I tried to fix them as I saw fit but could someone verify that I have updated these tests correctly?

excitement-engineer and others added some commits Dec 31, 2017

@rosskevin rosskevin requested a review from jbaxleyiii Jan 2, 2018

@rosskevin

This comment has been minimized.

Copy link
Collaborator

rosskevin commented Jan 2, 2018

@excitement-engineer some tsc errors now - not sure if due to other PRs merging or a mistake.

@excitement-engineer

This comment has been minimized.

Copy link
Collaborator Author

excitement-engineer commented Jan 2, 2018

That was a mistake:) I fixed it, thanks for taking a look!

@jbaxleyiii
Copy link
Member

jbaxleyiii left a comment

This is great! I'm surprised I never wrote a test for this but the snapshot is perfect! Thank you!

@jbaxleyiii jbaxleyiii merged commit f3b806c into apollographql:master Jan 4, 2018

4 checks passed

CLA Author has signed the Meteor CLA.
Details
bundlesize ./lib/umd/react-apollo.js: 4.67KB < maxSize 4.7KB gzip (same as master)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 96.181%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment