New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render callback should be typed with TData #1519

Merged
merged 5 commits into from Jan 5, 2018

Conversation

Projects
None yet
2 participants
@rosskevin
Copy link
Collaborator

rosskevin commented Jan 5, 2018

Missing parameterized type propagation in Query component

rosskevin added some commits Jan 5, 2018

@excitement-engineer
Copy link
Collaborator

excitement-engineer left a comment

Just one comment. If it is fixed then it is good for merging.

@@ -70,7 +70,7 @@ export interface QueryState<TData = any> {
}

class Query<TData = any> extends React.Component<
QueryProps,
QueryProps<TData>,

This comment has been minimized.

@excitement-engineer

excitement-engineer Jan 5, 2018

Collaborator

Can you also update the type definition of the props in the constructor.

This comment has been minimized.

@rosskevin

rosskevin Jan 5, 2018

Author Collaborator

Good catch

rosskevin added some commits Jan 5, 2018

@rosskevin rosskevin merged commit 20dd0c2 into apollographql:master Jan 5, 2018

4 checks passed

CLA Author has signed the Meteor CLA.
Details
bundlesize ./lib/umd/react-apollo.js: 4.67KB < maxSize 4.7KB gzip (same as master)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 96.181%
Details

@rosskevin rosskevin deleted the rosskevin:query-data-type-fix branch Jan 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment