New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get that preact support! #1561

Merged
merged 4 commits into from Jan 17, 2018

Conversation

Projects
None yet
2 participants
@jbaxleyiii
Copy link
Member

jbaxleyiii commented Jan 17, 2018

Try to get some preact support (mainly a PR to see if the tests all pass), need to add preact specific testing if it does.

https://twitter.com/_developit/status/953646725327138817

Still need to alias attributes/props and tag/vNode

@jbaxleyiii jbaxleyiii force-pushed the preact-maybe branch from 0af1732 to 07eb0a0 Jan 17, 2018

@peggyrayzis
Copy link
Member

peggyrayzis left a comment

Looks awesome so far, thanks for figuring out the testing config!! 🎉 Can't wait until this ships!

@peggyrayzis peggyrayzis merged commit 9222ab3 into master Jan 17, 2018

5 checks passed

CLA Author has signed the Meteor CLA.
Details
bundlesize ./lib/umd/react-apollo.js: 4.75KB < maxSize 4.8KB gzip (19B larger than master, careful!)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.006%) to 96.252%
Details

@peggyrayzis peggyrayzis deleted the preact-maybe branch Jan 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment