New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browser #1578

Merged
merged 4 commits into from Jan 25, 2018

Conversation

Projects
None yet
3 participants
@jbaxleyiii
Copy link
Member

jbaxleyiii commented Jan 25, 2018

@rosskevin in my testing the inclusion of react-dom blew up ReactNative and some older build systems. Also, without a single bundle, we can't support usage of unpkg.org which I'd like to keep for people using it!

This also fixes the precommit hooks with husky which weren't working previously and removes using yarn since its not a required part of the node ecosystem

@jbaxleyiii jbaxleyiii merged commit e6af730 into master Jan 25, 2018

4 of 5 checks passed

bundlesize ./lib/react-apollo.browser.umd.js: 5.81KB > maxSize 5.81KB gzip
Details
CLA Author has signed the Meteor CLA.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.006%) to 96.29%
Details

@jbaxleyiii jbaxleyiii deleted the browser branch Jan 25, 2018

@rosskevin

This comment has been minimized.

Copy link
Collaborator

rosskevin commented Jan 29, 2018

@jbaxleyiii it looks like you removed husky - which is the precommit hook, and added a script called precommit, which is not using git hooks. So we have no more git hook. What am I missing?

@@ -3,48 +3,45 @@
"version": "2.1.0-alpha.0",
"description": "React data container for Apollo Client",
"module": "src/index.ts",
"browser": "lib/react-apollo.browser.umd.js",

This comment has been minimized.

@FredyC

FredyC Mar 15, 2018

@jbaxleyiii I don't understand why this change was necessary. Doesn't it mean that eg. Webpack cannot do tree shaking? Besides it's broken altogether :) #1591 and this is from debugger

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment