New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added prop-types validation to unchecked components. #1587

Merged
merged 3 commits into from Feb 17, 2018

Conversation

Projects
None yet
3 participants
@excitement-engineer
Copy link
Collaborator

excitement-engineer commented Jan 27, 2018

Added prop-types validation to the <Query />, <Subscription /> and <ApolloConsumer /> component

@rosskevin
Copy link
Collaborator

rosskevin left a comment

Please increase the bundle size - otherwise looks good.

@jbaxleyiii

This comment has been minimized.

Copy link
Member

jbaxleyiii commented Jan 29, 2018

ugh, I hate prop-types in libraries but since we use context I guess we have them already? With the move to react's new context though I wonder if depending on prop-types will be necessary? If not, I'd like to not ship them anymore?

Thoughts? Are they still used / valuable?

@excitement-engineer

This comment has been minimized.

Copy link
Collaborator Author

excitement-engineer commented Jan 31, 2018

I personally don't use them as I use flow on all my react projects. However, for those that don't use any typings they could be valuable. I know that react-router uses them for example.

excitement-engineer and others added some commits Jan 31, 2018

James Baxley

@jbaxleyiii jbaxleyiii merged commit 1426447 into apollographql:master Feb 17, 2018

4 checks passed

CLA Author has signed the Meteor CLA.
Details
bundlesize ./dist/bundlesize.js: 10.52KB < maxSize 11KB (gzip)(40B larger than master, careful!)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.02%) to 96.379%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment