New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollback importing non esm packages #1621

Merged
merged 2 commits into from Feb 2, 2018

Conversation

Projects
None yet
2 participants
@leoasis
Copy link
Collaborator

leoasis commented Feb 2, 2018

This PR rolls back the imports of non esm packages. This breaks the bundles as they try to import those and access their default property.

@leoasis leoasis requested review from rosskevin and jbaxleyiii Feb 2, 2018

@leoasis leoasis merged commit 05c5b65 into apollographql:master Feb 2, 2018

4 checks passed

CLA Author has signed the Meteor CLA.
Details
bundlesize ./lib/react-apollo.browser.umd.js: 6.06KB < maxSize 6.5KB (gzip)(27B smaller than master, good job!)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.6%) to 96.032%
Details

@leoasis leoasis deleted the leoasis:fix_non_esm_imports branch Feb 2, 2018

@rosskevin

This comment has been minimized.

Copy link
Collaborator

rosskevin commented Feb 2, 2018

Fixes broken release, but reopens #1589

jamesreggio referenced this pull request Feb 3, 2018

James Baxley
Browser (#1578)
* add back in browser / server for RN and next support

* remove vscode

* updated precommit hook

* verify husky
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment