New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added "called" prop to the Mutation component #1775

Merged
merged 1 commit into from Mar 16, 2018

Conversation

Projects
None yet
4 participants
@excitement-engineer
Copy link
Collaborator

excitement-engineer commented Mar 10, 2018

Added a "called" field in the MutationResult prop returned in the render prop of the Mutation component. This field is true or false depending on whether the mutation has been called previously.

Adding this field ensures that the MutationResult object in the render prop is always defined which makes destructuring easier. In addition, this will prevent confusion about the meaning of an undefined MutationResult in the render prop as mentioned by #1773.

Would love to hear some feedback regarding these changes. Does this improve the experience of using the Mutation component.

@fbartho

This comment has been minimized.

Copy link

fbartho commented Mar 12, 2018

This is a breaking API change, but it really makes sense to me. I support this!

@jbaxleyiii jbaxleyiii merged commit fede11c into apollographql:master Mar 16, 2018

4 checks passed

CLA Author has signed the Meteor CLA.
Details
bundlesize ./dist/bundlesize.js: 10.54KB < maxSize 11KB (gzip)(7B larger than master, careful!)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 96.734%
Details
@janhartmann

This comment has been minimized.

Copy link

janhartmann commented Mar 19, 2018

This is so much needed - I was upgrading our system to the beta version, but I ran into these undefined issues but could not understand why, after viewing the source code of the Mutation component.

It was because this change is not yet released. I can not wait! Nice work, guys!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment