New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subs #256

Merged
merged 3 commits into from Oct 8, 2016

Conversation

Projects
None yet
1 participant
@jbaxleyiii
Copy link
Member

jbaxleyiii commented Oct 8, 2016

Integrated subscriptions!

@graphql(gql`subscription { user { name } }`)
class MyComponentWithSubscription extends Component {
  //
}

TODO:

  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass
  • Update CHANGELOG.md with your change
  • If this was a change that affects the external API, update the docs and post a link to the PR in the discussion

going to quietly ship this and test it in production before adding to the api docs

James Baxley added some commits Oct 8, 2016

James Baxley
James Baxley

@jbaxleyiii jbaxleyiii merged commit a23883f into master Oct 8, 2016

5 checks passed

./dist/index.min.js +811 bytes (+2.92%) → 27,740 bytes
CLA Author has signed the Meteor CLA.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.2%) to 96.068%
Details

@jbaxleyiii jbaxleyiii deleted the subs branch Oct 8, 2016

@jbaxleyiii jbaxleyiii referenced this pull request Oct 8, 2016

Closed

Revert "Subs" #257

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment