New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Apollo Client 0.5 #277

Merged
merged 13 commits into from Oct 18, 2016

Conversation

Projects
None yet
3 participants
@stubailo
Copy link
Member

stubailo commented Oct 18, 2016

Blockers:

Tests passing:

  • test
  • ├── parser.test.ts
  • ├── react-native
  • │   ├── snapshots
  • │   │   └── component.test.js.snap
  • │   └── component.test.js
  • └── react-web
  • ├── client
  • │   ├── ApolloProvider.test.tsx
  • │   ├── graphql
  • │   │   ├── fragments.test.tsx
  • │   │   ├── mutations.test.tsx
  • │   │   ├── queries-1.test.tsx
  • │   │   ├── queries-2.test.tsx
  • │   │   ├── shared-operations-1.test.tsx
  • │   │   ├── shared-operations-2.test.tsx
  • │   │   ├── statics.test.tsx
  • │   │   └── subscriptions.test.tsx
  • │   └── libraries
  • │   ├── mobx.test.tsx
  • │   ├── redux-1.test.tsx
  • │   └── redux-2.test.tsx
  • └── server
  • └── index.test.tsx

TODO:

  • If this PR is a new feature, reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass
  • Update CHANGELOG.md with your change
  • If this was a change that affects the external API, update the docs and post a link to the PR in the discussion

stubailo added some commits Oct 18, 2016

@@ -21,7 +21,7 @@ describe('App', () => {
const query = gql`query people { allPeople(first: 1) { people { name } } }`;
const data = { allPeople: { people: { name: 'Luke Skywalker' } } };
const networkInterface = mockNetworkInterface({ request: { query }, result: { data } });
const client = new ApolloClient({ networkInterface });
const client = new ApolloClient({ networkInterface, addTypename: false });

This comment has been minimized.

@tmeasday

tmeasday Oct 18, 2016

Contributor

Why do this all over the place and default the network interface to supporting it?

This comment has been minimized.

@stubailo

stubailo Oct 18, 2016

Author Member

What's the alternative?

This comment has been minimized.

@tmeasday

tmeasday Oct 18, 2016

Contributor

I thought we discussed making mockNetworkInterface support adding __typename to results automatically so we didn't have to worry about it in tests.

This comment has been minimized.

@stubailo

stubailo Oct 18, 2016

Author Member

Oh, right. I guess this seemed easier for now.

This comment has been minimized.

@tmeasday

tmeasday Oct 18, 2016

Contributor

Yeah I guess it just seems like the sort of change that is hard to back out later. But i'll merge it and do that later today.

@tmeasday tmeasday merged commit b18ceb4 into master Oct 18, 2016

5 checks passed

./dist/index.min.js -1,271 bytes (-7.28%) → 17,464 bytes
CLA Author has signed the Meteor CLA.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 96.737%
Details
@@ -66,8 +65,18 @@ const defaultMapResultToProps = props => props;
const defaultMapPropsToSkip = props => false;

// the fields we want to copy over to our data prop
const observableQueryFields = observable => pick(observable, 'variables',
'refetch', 'fetchMore', 'updateQuery', 'startPolling', 'stopPolling');
function observableQueryFields(observable) {

This comment has been minimized.

@stubailo

stubailo Oct 18, 2016

Author Member

@tmeasday @helfer I just realized I forgot to add subscribeToMore here.

This comment has been minimized.

@helfer

helfer Oct 18, 2016

Member

patch release?

This comment has been minimized.

@helfer

helfer Oct 18, 2016

Member

Or do we just wait?

This comment has been minimized.

@stubailo

stubailo Oct 18, 2016

Author Member

I can patch. I don't think there's a big cost to more releases right.

@calebmer calebmer deleted the apollo-0.5 branch Mar 1, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment