New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with usage in TypeScript projects caused by 'compose' re-export #291

Merged
merged 1 commit into from Oct 28, 2016

Conversation

Projects
None yet
3 participants
@vlasenko
Copy link
Contributor

vlasenko commented Oct 27, 2016

Fixes #279

As suggested by @migueloller compose is re-exported from redux instead of recompose, since implementation is completely the same, that's why we can drop depending on recompose completely.

TODO:

  • If this PR is a new feature, reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass
  • Update CHANGELOG.md with your change
  • If this was a change that affects the external API, update the docs and post a link to the PR in the discussion
@@ -2,6 +2,6 @@ import ApolloProvider from './ApolloProvider';
import graphql, { withApollo } from './graphql';

// expose easy way to join queries from recompose

This comment has been minimized.

@migueloller

migueloller Oct 27, 2016

Update the comment to say redux instead of recompose?

This comment has been minimized.

@vlasenko

vlasenko Oct 27, 2016

Author Contributor

Thank you! Done

@migueloller

This comment has been minimized.

Copy link

migueloller commented Oct 27, 2016

Would it make sense to rebase so that the commit that removes the recompose dependency also imports from redux? This way the commit makes a non-breaking atomic change and can easily be reverted if necessary.

EDIT: This won't matter if the PR is squashed.

@vlasenko

This comment has been minimized.

Copy link
Contributor Author

vlasenko commented Oct 27, 2016

Sure. I will try now. I never did this before.... Any pointers appreciated

@vlasenko

This comment has been minimized.

Copy link
Contributor Author

vlasenko commented Oct 27, 2016

Okay, rebased everything into single commit

@jbaxleyiii

This comment has been minimized.

Copy link
Member

jbaxleyiii commented Oct 28, 2016

@vlasenko this is great, my only concern is with importing all of redux. This probably isn't an issue since apollo-client imports redux. Technically this integration doesn't actually rely on redux at all.

That being said, I'm great with this for now! Thanks for the PR

@jbaxleyiii jbaxleyiii merged commit 1e4249e into apollographql:master Oct 28, 2016

3 checks passed

CLA Author has signed the Meteor CLA.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 96.565%
Details

@jbaxleyiii jbaxleyiii referenced this pull request Oct 28, 2016

Closed

Fix #279 #285

0 of 6 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment