New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix forceFetch on SSR #293

Merged
merged 3 commits into from Oct 28, 2016

Conversation

Projects
None yet
2 participants
@jbaxleyiii
Copy link
Member

jbaxleyiii commented Oct 28, 2016

Fix for #292

TODO:

  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass
  • Update CHANGELOG.md with your change

James Baxley added some commits Oct 28, 2016

James Baxley
James Baxley

@jbaxleyiii jbaxleyiii merged commit 71bad83 into master Oct 28, 2016

5 checks passed

./dist/index.min.js +34 bytes (+0.12%) → 27,530 bytes
CLA Author has signed the Meteor CLA.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.01%) to 96.578%
Details

@jbaxleyiii jbaxleyiii deleted the 292 branch Oct 28, 2016

@tmeasday

This comment has been minimized.

Copy link
Contributor

tmeasday commented Nov 1, 2016

Interesting. We added a ssrMode: true to AC which simply ignores forceFetch to get around this problem originally.

I don't recall if we had an idea at the time of use cases where people might validly want to force fetch in SSR (and thus not set the option). Probably not huh? If so, we should remove ssrMode as an option to AC (and make sure the angular SSR works the same way).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment