New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass component display name to watchQuery metadata. #363

Merged
merged 1 commit into from Dec 9, 2016

Conversation

Projects
None yet
3 participants
@glasser
Copy link
Contributor

glasser commented Dec 8, 2016

TODO:

  • If this PR is a new feature, reference an issue where a consensus about the design was reached (not necessary for small changes) — discussed in person
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass
  • Update CHANGELOG.md with your change
  • If this was a change that affects the external API, update the docs and post a link to the PR in the discussion

Metadata is a new feature added in apollo-client@0.5.13

@glasser glasser requested a review from stubailo Dec 8, 2016

@zol zol added the in progress label Dec 8, 2016

@glasser glasser force-pushed the glasser/watch-metadata branch from 01dcb2f to 953734e Dec 8, 2016

@jbaxleyiii

This comment has been minimized.

Copy link
Member

jbaxleyiii commented Dec 9, 2016

@glasser will this require a certain version of AC?

@glasser

This comment has been minimized.

Copy link
Contributor Author

glasser commented Dec 9, 2016

Yes (0.5.13), but I think it's fine to not strictly require that version in the peer deps since it'll just get ignored otherwise.

Pass component display name to watchQuery metadata.
Metadata is a new feature added in apollo-client@0.5.13. It's OK to pass
the option in to older clients; it will just be ignored.

This will be used by Apollo Chrome DevTools!

@glasser glasser force-pushed the glasser/watch-metadata branch from 953734e to 39fe372 Dec 9, 2016

@jbaxleyiii
Copy link
Member

jbaxleyiii left a comment

💯

@jbaxleyiii jbaxleyiii merged commit 02fe991 into master Dec 9, 2016

5 checks passed

./dist/index.min.js +42 bytes (+0.15%) → 27,978 bytes
CLA Author has signed the Meteor CLA.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.4%) to 94.378%
Details

@jbaxleyiii jbaxleyiii deleted the glasser/watch-metadata branch Dec 9, 2016

@zol zol removed the in progress label Dec 9, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment