New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move react-dom to optionalDependencies, fix #402 #403

Merged
merged 1 commit into from Jan 9, 2017

Conversation

Projects
None yet
4 participants
@secretfader
Copy link
Contributor

secretfader commented Jan 7, 2017

This clears up the error on React Native.

@meteor-bot

This comment has been minimized.

Copy link

meteor-bot commented Jan 7, 2017

@nicholaswyoung: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

@jbaxleyiii

This comment has been minimized.

Copy link
Member

jbaxleyiii commented Jan 9, 2017

LGTM! Thanks!

@jbaxleyiii jbaxleyiii merged commit 03a6216 into apollographql:master Jan 9, 2017

3 checks passed

CLA Author has signed the Meteor CLA.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.2%) to 94.664%
Details

@secretfader secretfader deleted the fix/optional-react-dom branch Jan 10, 2017

@daniel-nagy

This comment has been minimized.

Copy link

daniel-nagy commented Jan 22, 2017

@jbaxleyiii Can you publish v0.8.2?

@jbaxleyiii

This comment has been minimized.

Copy link
Member

jbaxleyiii commented Jan 22, 2017

@daniel-nagy sorry! sure thing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment