Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix silent errors #476
Logs an error to the console now instead of silently ignoring errors when a user does not explicitly use the
This is one of the error changes we wanted to make for AC 1.0.
Interestingly enough, this change caught a couple of bugs in our test suite
@jbaxleyiii as far as I know it’s a safe assumption that React Native logs will always be slow
However, for just printing an error stack trace which is a few bytes of text I highly doubt there will be any performance impact. The real killers for logging in React Native are sophisticated logging libraries like
Also, users should really be expected to catch and handle these errors, so even if there is some performance impact on the rare event there is an error it is a (mostly) one time cost and it has an easy fix on the user’s part.