New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.0.0 rc.2 #520

Merged
merged 10 commits into from Mar 10, 2017

Conversation

Projects
None yet
2 participants
@helfer
Copy link
Member

helfer commented Mar 10, 2017

Let's see what breaks 馃挜

@helfer

This comment has been minimized.

Copy link
Member Author

helfer commented Mar 10, 2017

Too bad I can't review my own PR 馃槥 Good thing I can still merge it though 馃槃

@stubailo

This comment has been minimized.

Copy link
Member

stubailo commented Mar 10, 2017

Maybe you should make the tests pass :P

@helfer

This comment has been minimized.

Copy link
Member Author

helfer commented Mar 10, 2017

Yeah, maybe next time I'll run those before pushing. Tends to look a bit cleaner 馃槵

@helfer

This comment has been minimized.

Copy link
Member Author

helfer commented Mar 10, 2017

@stubailo @calebmer since I had to change a few more things than just the Changelog and the version, a quick review by one of you would be great!

@@ -22,6 +22,7 @@ import ApolloClient, {
ApolloStore,
ApolloQueryResult,
ApolloError,
// FetchPolicy,

This comment has been minimized.

@stubailo

stubailo Mar 10, 2017

Member

What's up with this

This comment has been minimized.

@helfer

helfer Mar 10, 2017

Author Member

Unfortunately it's not exported by Apollo Client yet. "Someone" forgot to export it. We'll add it in the next release.

@helfer helfer changed the title 1.0.0 rc.1 1.0.0 rc.2 Mar 10, 2017

@helfer

This comment has been minimized.

Copy link
Member Author

helfer commented Mar 10, 2017

Alright, this is it!

@helfer helfer merged commit 39ef50a into master Mar 10, 2017

5 checks passed

./dist/index.min.js +28 bytes (+0.06%) 鈫 48,819 bytes
CLA Author has signed the Meteor CLA.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls First build on v1.0.0-rc.2 at 93.25%
Details

@helfer helfer deleted the 1.0.0-rc.1 branch Mar 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment