Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upRemove unused `immutable` prop from ApolloProvider #539
Conversation
This comment has been minimized.
This comment has been minimized.
meteor-bot
commented
Mar 18, 2017
|
@mdebbar: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/ |
thebigredgeek
requested a review
from
jbaxleyiii
Apr 25, 2017
thebigredgeek
added
the
waiting on contributor
label
Apr 25, 2017
This comment has been minimized.
This comment has been minimized.
|
@mdebbar can you update the tests so that the build passes? |
thebigredgeek
and others
added some commits
Apr 25, 2017
This comment has been minimized.
This comment has been minimized.
|
@thebigredgeek I think the failure you saw was intermittent. I did |
This comment has been minimized.
This comment has been minimized.
|
Immutable support never did catch on did it haha. Thanks for cleaning this up! |
jbaxleyiii
approved these changes
Apr 29, 2017
jbaxleyiii
merged commit 56e0b1b
into
apollographql:master
Apr 29, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
mdebbar commentedMar 18, 2017
No description provided.