Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upFIXES don't lock down React peer dependency to exact version #626
Conversation
This comment has been minimized.
This comment has been minimized.
meteor-bot
commented
Apr 13, 2017
|
@kimpers: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/ |
This comment has been minimized.
This comment has been minimized.
|
This looks good, but we need to merge #628 first to make the tests pass I think. |
stubailo
added some commits
Apr 13, 2017
stubailo
merged commit 04a2afb
into
apollographql:master
Apr 13, 2017
This comment has been minimized.
This comment has been minimized.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
kimpers commentedApr 13, 2017
Version 1.0.2 changes the peer dependency to exactly
15.5.0, this seems to have been due to a green keeper update and may not have been intentional. This new exact version lockdown causes a lot of conflicts with other dependencies and should be reverted.TODO: