New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIXES don't lock down React peer dependency to exact version #626

Merged
merged 4 commits into from Apr 13, 2017

Conversation

Projects
None yet
3 participants
@kimpers
Copy link
Contributor

kimpers commented Apr 13, 2017

Version 1.0.2 changes the peer dependency to exactly 15.5.0, this seems to have been due to a green keeper update and may not have been intentional. This new exact version lockdown causes a lot of conflicts with other dependencies and should be reverted.
TODO:

  • Update CHANGELOG.md with your change
@meteor-bot

This comment has been minimized.

Copy link

meteor-bot commented Apr 13, 2017

@kimpers: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

@stubailo

This comment has been minimized.

Copy link
Member

stubailo commented Apr 13, 2017

This looks good, but we need to merge #628 first to make the tests pass I think.

@stubailo stubailo merged commit 04a2afb into apollographql:master Apr 13, 2017

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
CLA Author has signed the Meteor CLA.
Details
@stubailo

This comment has been minimized.

Copy link
Member

stubailo commented Apr 13, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment