New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-export everything from apollo-client #650

Merged
merged 3 commits into from Apr 28, 2017

Conversation

Projects
None yet
4 participants
@benhjames
Copy link
Contributor

benhjames commented Apr 23, 2017

Fixes #521. :)

TODO:

  • If this PR is a new feature, reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass
  • Update CHANGELOG.md with your change
  • If this was a change that affects the external API, update the docs and post a link to the PR in the discussion
@meteor-bot

This comment has been minimized.

Copy link

meteor-bot commented Apr 23, 2017

@benhjames: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

@thebigredgeek

This comment has been minimized.

Copy link
Contributor

thebigredgeek commented Apr 25, 2017

@helfer lgtm. thoughts?

// expose easy way to join queries from redux
export { compose } from 'redux';

// re-exports of close dependencies.
export { default as ApolloClient, createNetworkInterface, createBatchingNetworkInterface } from 'apollo-client';
export * from 'apollo-client';

This comment has been minimized.

@helfer

helfer Apr 26, 2017

Member

Will that export the default as ApolloClient? We should make sure that's the case. Otherwise we should just list all the things that we want to export. It's okay if there are a few things missing occasionally, because people can always import directly from apollo-client as a workaround.

This comment has been minimized.

@benhjames

benhjames Apr 26, 2017

Author Contributor

ApolloClient is also a named export from apollo-client (as well as the default export) so it should make no difference.

Ref: https://github.com/apollographql/apollo-client/blob/master/src/index.ts#L121

@helfer

helfer approved these changes Apr 28, 2017

Copy link
Member

helfer left a comment

Ok, I'm convinced.

@helfer helfer merged commit 8dd277d into apollographql:master Apr 28, 2017

3 checks passed

CLA Author has signed the Meteor CLA.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.1%) to 92.308%
Details

@benhjames benhjames deleted the benhjames:fix-exports branch Apr 28, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment