New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix server side rendering when using the `cache-and-network` fetchPolicy #688

Merged
merged 2 commits into from May 4, 2017

Conversation

Projects
None yet
2 participants
@amannn
Copy link
Contributor

amannn commented May 4, 2017

As discussed in #328.

I've added a test that passes now with the adapted logic in graphql.tsx. I'm not quite confident if it is the right way to go though, so I'd appreciate a review 馃檪.

TODO:

  • If this PR is a new feature, reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass
  • Update CHANGELOG.md with your change
  • If this was a change that affects the external API, update the docs and post a link to the PR in the discussion

amannn added some commits May 4, 2017

@jbaxleyiii jbaxleyiii merged commit 1452b3c into apollographql:master May 4, 2017

3 checks passed

CLA Author has signed the Meteor CLA.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 92.255%
Details
@jbaxleyiii

This comment has been minimized.

Copy link
Member

jbaxleyiii commented May 4, 2017

@amannn this is great! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment