New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use React API forceUpdate() for forceRenderChildren(). #775

Merged
merged 3 commits into from Jul 5, 2017

Conversation

Projects
None yet
3 participants
@baerrach
Copy link
Contributor

baerrach commented Jun 14, 2017

Patch for #773

Using setState({}) causes unnecessary re-renders as {} is always a new object.

TODO:

  • If this PR is a new feature, reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests
  • Rebase your changes on master so that they can be merged easily
  • Make sure all tests and linter rules pass
  • Update CHANGELOG.md with your change
  • If this was a change that affects the external API, update the docs and post a link to the PR in the discussion
  • If this was a change that affects GitHunt-React, update GitHunt-React and post a link to the PR in the discussion
Use React API forceUpdate() for forceRenderChildren().
Using setState({}) causes unnecessary re-renders as {} is always a new object.
@helfer

helfer approved these changes Jun 14, 2017

Copy link
Member

helfer left a comment

LGTM

James Baxley added some commits Jul 5, 2017

@jbaxleyiii jbaxleyiii merged commit 590847b into apollographql:master Jul 5, 2017

3 checks passed

CLA Author has signed the Meteor CLA.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 92.295%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment