New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/804 #865

Merged
merged 4 commits into from Jul 19, 2017

Conversation

Projects
None yet
3 participants
@akomm
Copy link
Contributor

akomm commented Jul 19, 2017

Test & fix for issue #804

fixes #804

Andriy Komm added some commits Jul 19, 2017

Andriy Komm
@meteor-bot

This comment has been minimized.

Copy link

meteor-bot commented Jul 19, 2017

@akomm: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

Andriy Komm
@akomm

This comment has been minimized.

Copy link
Contributor Author

akomm commented Jul 19, 2017

Same test passed locally. Weird. must be environment-dependent.

@jbaxleyiii

This comment has been minimized.

Copy link
Member

jbaxleyiii commented Jul 19, 2017

@akomm I'm afraid the tests have been flaky of late. I need to look into why

James Baxley
@jbaxleyiii

This comment has been minimized.

Copy link
Member

jbaxleyiii commented Jul 19, 2017

@akomm thank you for this great contribution! I'll merge and release it asap!

@jbaxleyiii jbaxleyiii merged commit d2bac92 into apollographql:master Jul 19, 2017

5 checks passed

CLA Author has signed the Meteor CLA.
Details
Danger All green. Well done.
Details
bundlesize ./dist/index.min.js: 11.64kB < threshold 20kB gzip (18B larger than master, careful!)
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.2%) to 91.719%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment