New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move from string ref to callback ref #908

Merged
merged 4 commits into from Aug 1, 2017

Conversation

Projects
None yet
4 participants
@koenpunt
Copy link
Contributor

koenpunt commented Jul 31, 2017

since string refs are legacy

https://facebook.github.io/react/docs/refs-and-the-dom.html#legacy-api-string-refs

Checklist:

  • If this PR is a new feature, please reference an issue where a consensus about the design was reached (not necessary for small changes)
  • Make sure all of the significant new logic is covered by tests
  • If this was a change that affects the external API used in GitHunt-React, update GitHunt-React and post a link to the PR in the discussion.
@mention-bot

This comment has been minimized.

Copy link

mention-bot commented Jul 31, 2017

@koenpunt, thanks for your PR! By analyzing the history of the files in this pull request, we identified @jbaxleyiii to be a potential reviewer.

@jbaxleyiii

This comment has been minimized.

Copy link
Member

jbaxleyiii commented Jul 31, 2017

@koenpunt thank you for this! I'm happy to merge it once the CI comes back green 👍

@koenpunt koenpunt force-pushed the koenpunt:patch-1 branch from fdc6b42 to 48ff1f5 Jul 31, 2017

@koenpunt koenpunt force-pushed the koenpunt:patch-1 branch from 48ff1f5 to 90b9df6 Jul 31, 2017

@koenpunt

This comment has been minimized.

Copy link
Contributor Author

koenpunt commented Jul 31, 2017

Oh well, that was Github's annoying auto-whitespace-insert in the online editor.
Should be all good now, also cleaned up the commits.

@jbaxleyiii jbaxleyiii merged commit 742e9b2 into apollographql:master Aug 1, 2017

4 checks passed

CLA Author has signed the Meteor CLA.
Details
Danger All green. Good on 'ya.
Details
bundlesize ./dist/index.min.js: 11.66kB < maxSize 12kB gzip (22B larger than master, careful!)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@koenpunt koenpunt deleted the koenpunt:patch-1 branch Aug 1, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment