New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MockNetworkInterface match mock requests regardless of variable order #973

Merged
merged 2 commits into from Aug 13, 2017

Conversation

Projects
None yet
4 participants
@L1fescape
Copy link
Contributor

L1fescape commented Aug 11, 2017

Currently mock data needs to exactly match the request being made within a component being tested. This is because requests object are stringified and used as keys when registering and looking up the corresponding response objects to be returned. This change sorts the request object when it is stringified so the order of variables doesn't matter.

This issue is discussed in #674

@meteor-bot

This comment has been minimized.

Copy link

meteor-bot commented Aug 11, 2017

@L1fescape: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

@mention-bot

This comment has been minimized.

Copy link

mention-bot commented Aug 11, 2017

@L1fescape, thanks for your PR! By analyzing the history of the files in this pull request, we identified @jbaxleyiii, @calebmer and @mmissey to be potential reviewers.

@jbaxleyiii

This comment has been minimized.

Copy link
Member

jbaxleyiii commented Aug 13, 2017

@L1fescape thank you! This looks great to me!

@jbaxleyiii jbaxleyiii merged commit 7308d20 into apollographql:master Aug 13, 2017

4 checks passed

CLA Author has signed the Meteor CLA.
Details
Danger All green. Jolly good show.
Details
bundlesize ./dist/index.min.js: 11.66kB < maxSize 12kB gzip (same as master)
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment