/react-apollo

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't strip data away from the component when the query errors #98

Merged
merged 1 commit into from Jul 11, 2016

Conversation

Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@rricard @jbaxleyiii
@rricard
Copy link
Member

rricard commented Jul 8, 2016

Fixes #97
@rricard
Get back the oldData in case the query errored 
It will be empty anyway on the first fetch. But on a force refetch or
polling, it won't empty the component from its data while still adding
the errors. to it.

Fixes #97
Loading status checks…
79c233e

@rricard rricard referenced this pull request Jul 8, 2016

Closed

Polling (and force fetch in general) while the client is disconnected empties the store after erroring #334

@jbaxleyiii

This comment has been minimized.

Sign in to view
Copy link
Member

jbaxleyiii commented Jul 11, 2016

Thanks @rricard!

@jbaxleyiii jbaxleyiii merged commit dbb03dd into apollographql:master Jul 11, 2016
3 checks passed

3 checks passed

CLA Author has signed the Meteor CLA.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage remained the same at 95.946%
Details

@rricard rricard deleted the rricard:dont-drop-data-on-error branch Jul 11, 2016

@StevePotter StevePotter referenced this pull request Mar 2, 2017

Closed

Don't strip data away from the component when the query errors #500

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment