Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upHave @connect hoist statics #99
Conversation
nevir
added some commits
Jul 8, 2016
This comment has been minimized.
This comment has been minimized.
meteor-bot
commented
Jul 8, 2016
|
@nevir: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/ |
This comment has been minimized.
This comment has been minimized.
|
@nevir this is awesome. Thanks! |
jbaxleyiii
merged commit 311ef4f
into
apollographql:master
Jul 8, 2016
This comment has been minimized.
This comment has been minimized.
|
Awesome! |
nevir
deleted the
convoyinc:hoist-statics
branch
Aug 11, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
nevir commentedJul 8, 2016
Currently,
react-apollo's@connectstrips any custom statics from the components it wraps; this'll preserve them, using the same method employed byreact-redux.