New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have @connect hoist statics #99

Merged
merged 2 commits into from Jul 8, 2016

Conversation

Projects
None yet
4 participants
@nevir
Copy link
Contributor

nevir commented Jul 8, 2016

Currently, react-apollo's @connect strips any custom statics from the components it wraps; this'll preserve them, using the same method employed by react-redux.

nevir added some commits Jul 8, 2016

Have @connect hoist statics
Currently, `react-apollo`'s `@connect` strips any custom statics from the components it wraps; this'll preserve them, using the [same method employed by `react-redux`](https://github.com/reactjs/react-redux/blob/master/src/components/connect.js#L365)
@meteor-bot

This comment has been minimized.

Copy link

meteor-bot commented Jul 8, 2016

@nevir: Thank you for submitting a pull request! Before we can merge it, you'll need to sign the Meteor Contributor Agreement here: https://contribute.meteor.com/

@jbaxleyiii

This comment has been minimized.

Copy link
Member

jbaxleyiii commented Jul 8, 2016

@nevir this is awesome. Thanks!

@jbaxleyiii jbaxleyiii merged commit 311ef4f into apollographql:master Jul 8, 2016

3 checks passed

CLA Author has signed the Meteor CLA.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.04%) to 95.982%
Details
@stubailo

This comment has been minimized.

Copy link
Member

stubailo commented Jul 9, 2016

Awesome!

@nevir nevir deleted the convoyinc:hoist-statics branch Aug 11, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment