You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It turns out loading a super graph that contains validation errors will fail on the Router service builder (as expected). However when the telemetry plugin is enabled the router will hang.
Steps to reproduce:
Make this change in ./examples/graphql/local.graphql:
$ cargo r -- -c ./examples/telemetry/otlp.router.yaml -s ./examples/graphql/local.graphql
Expected: The router fails to start
Actual: The router hangs, it takes a kill -9 to get the shell back
Notice not providing -c will not set up telemetry and show an error instead such as:
$ cargo r -- -s ./examples/graphql/local.graphql
Finished dev [unoptimized + debuginfo] target(s) in 0.43s
Running `target/debug/router -s ./examples/graphql/local.graphql`
2022-04-13T16:26:41.753124Z INFO apollo_router::executable: apollo-router@0.1.0-preview.4
2022-04-13T16:26:41.805521Z INFO apollo_router: starting Apollo Router
2022-04-13T16:26:42.475415Z ERROR apollo_router::state_machine: cannot create the router: couldn't build Router Service: query planning had errors: bridge errors: UNKNOWN: Cannot find type Review in subgraph products2022-04-13T16:26:42.475559Z INFO apollo_router: stopped with error2022-04-13T16:26:42.475706Z ERROR apollo_router::executable: could not create the HTTP pipeline: couldn't build Router Service: query planning had errors: bridge errors: UNKNOWN: Cannot find type Review in subgraph products
could not create the HTTP pipeline: couldn't build Router Service: query planning had errors: bridge errors: UNKNOWN: Cannot find type Review in subgraph products
The text was updated successfully, but these errors were encountered:
fixes#847
The telemetry plugin would cause the router to hang if ServiceBuilder::build() failed.
This commit makes sure the Telemetry plugin is cleanly shutdown when it's the case, thus correctly erroring out instead of hanging.
It turns out loading a super graph that contains validation errors will fail on the Router service builder (as expected). However when the telemetry plugin is enabled the router will hang.
Steps to reproduce:
Notice not providing -c will not set up telemetry and show an error instead such as:
The text was updated successfully, but these errors were encountered: