provide rhai surrogate cache key example #1136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What is causing the de-serialization error?
To pull in Geoffroy's rhai contribution for serde. Clean up the example and think about the best way to expose upsert to rhai.
Fix the implementation of upsert() and update the example to use the new upsert().
Until the next release of rhai. Needed to pull in the fix for map serialization.
✅ Deploy Preview for apollo-router-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
This comment has been minimized.
This comment has been minimized.
bnjjj
reviewed
May 24, 2022
- Added feature line to changelog - (clean up dead commented out line in Cargo.toml) - Document new Context::upsert() support in rhai - Document new surrogate cache key example
code review comment
bnjjj
approved these changes
May 24, 2022
Geal
reviewed
May 24, 2022
| let map_callback = |response| { | ||
| try { | ||
| // IMPORTANT: Take a copy of the cache-key here | ||
| // to avoid deadlock in the closure. |
There was a problem hiding this comment.
maybe the documentation should have a section about that deadlock risk
There was a problem hiding this comment.
That's a general rhai risk rather than anything specific about how we use it. I will think about the best way to incorporate something that references this.
There was a problem hiding this comment.
I've added a section to the docs: 3f08c90
There was a problem hiding this comment.
@Geal Could you take a look at the changes I added?
Try to call out some of the dangers of deadlock with shared values.
Geal
approved these changes
May 25, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides an example of reading subgraph header responses and creating a composite surrogate key.
The approach taken is to override:
This approach makes use of the new Context::upsert() function which is added to the rhai implementation.
Note: The rhai dependency is bound to a specific git rev since we require a serialization fix in rhai (provided by @Geal ) and which hasn't been released yet.
fixes: #648