Make uplink logic ignore messages that are deemed older than the last message to be received #2803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… message to be received. The tests had to be refactored as we needed to be able to test ordering ID and this wasn't possible with entitlements. Fixes #2794
This comment has been minimized.
This comment has been minimized.
o0Ignition0o
approved these changes
Mar 17, 2023
BrynCooke
force-pushed
the
bryn/uplink-forward-only
branch
from
9c4c6ed
to
254a0e9
Compare
added 2 commits
March 17, 2023 15:45
BrynCooke
force-pushed
the
bryn/uplink-forward-only
branch
from
b88960f
to
e4eef91
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Messages that are received from uplink are filtered if they are deemed to be older than the last message recieved.
This should prevent flapping of routers especially when
APOLLO_UPLINK_ENDPOINTSis in use.The tests had to be refactored as we needed to be able to test ordering ID and this wasn't possible with entitlements.
Part of #2794
Checklist
Complete the checklist (and note appropriate exceptions) before a final PR is raised.
Exceptions
Note any exceptions here
Notes
[^1]. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this.
[^2]. Configuration is an important part of many changes. Where applicable please try to document configuration examples.
[^3]. Tick whichever testing boxes are applicable. If you are adding Manual Tests:
- please document the manual testing (extensively) in the Exceptions.
- please raise a separate issue to automate the test and label it (or ask for it to be labeled) as
manual test