Polling when server is down clears out results

[SachaG]

With polling enabled, I've noticed that if I shut down my dev server the next time polling triggers (and errors out), my query container doesn't return any results and all my data disappears. Is this the intended behavior? I'd have thought the old data would remain there?

[helfer]

@SachaG Thanks for pointing it out! That's probably never what the user wants, so we should change it. Luckily this shouldn't be hard to fix, all we need to do is ignore the result of a polling query if there is an error.

[nandito]

@SachaG could you be a bit more specific? I tried to reproduce the issue but it works for me. When I stopped the GraphQL server, I got the OPTIONS http://example.com/graphql net::ERR_CONNECTION_REFUSED console error but my sample app kept the previously fetched data in the store.

[SachaG]

It might be an issue with my app then… I'll close this until I can confirm this or give you more information.

[SachaG]

I had more time to look into this. I tried triggering an error on the server, and got this response:

But weirdly enough, the status code still shows 200:

Could that be why the container stops returning data?

[calebmer]

Would it be possible for you to reproduce this error with react-apollo-error-template? It would go a long way in helping us solve this issue because we could see exactly what’s happening 😊

[SachaG]

Sure, I'll see what I can do.

[helfer]

It should no longer clear out results in react-apollo with apollographql/react-apollo#548. For other integrations I think they should do a similar thing.