Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix log rotation #56

Merged
merged 3 commits into from May 3, 2019

Conversation

Projects
None yet
2 participants
@0xmchadha
Copy link
Contributor

commented May 3, 2019

Log rotation was broken when we want to log on both the file and console.

==========
Testing Done

Tested enforcer with custom log line in a loop. The file in /var/log/enforcerd at 10MB was backed up with the timestamp and a new file was used to write logs.

@0xmchadha 0xmchadha requested review from primalmotion and satyamsi May 3, 2019

Show resolved Hide resolved logutils/log.go Outdated
@primalmotion

This comment has been minimized.

Copy link
Member

commented May 3, 2019

/build

@codecov

This comment has been minimized.

Copy link

commented May 3, 2019

Codecov Report

Merging #56 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #56   +/-   ##
=======================================
  Coverage   90.19%   90.19%           
=======================================
  Files           7        7           
  Lines         367      367           
=======================================
  Hits          331      331           
  Misses         21       21           
  Partials       15       15
Impacted Files Coverage Δ
lombric/converters.go 100% <0%> (ø) ⬆️
updatesync/updatesync.go 100% <0%> (ø) ⬆️
appcreds/appcreds.go 81.81% <0%> (ø) ⬆️
tokenutils/audience.go 100% <0%> (ø) ⬆️
lombric/lombric.go 83.82% <0%> (ø) ⬆️
lombric/checks.go 85.18% <0%> (ø) ⬆️
tokenutils/tokenutils.go 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47f1c1f...e5e9344. Read the comment docs.

@0xmchadha 0xmchadha merged commit 886b313 into master May 3, 2019

3 of 4 checks passed

built
Details
codecov/patch Coverage not affected when comparing 47f1c1f...e5e9344
Details
codecov/project 90.19% remains the same compared to 47f1c1f
Details
unit-tests
Details

@0xmchadha 0xmchadha deleted the fix_log_rotation branch May 3, 2019

0xmchadha added a commit that referenced this pull request May 3, 2019

fix log rotation (#56)
Log rotation fixing when file and console are enabled.

satyamsi pushed a commit that referenced this pull request May 7, 2019

Satyam Sinha
Revert "fix log rotation (#56)"
This reverts commit 886b313.

satyamsi pushed a commit that referenced this pull request May 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.