Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new: faster push dispatch #76

Merged
merged 4 commits into from Oct 4, 2019

Conversation

@primalmotion
Copy link
Member

commented Oct 4, 2019

This fixes several performance issues.

  • filtering and exiting early
  • preparing data once for all
  • preventing allocations
primalmotion added 2 commits Oct 4, 2019
This fixes several performance issues.

- filtering and exiting early
- preparing data once for all
- preventing allocations
@primalmotion primalmotion changed the title small optimizations @primalmotion new: faster push dispatch Oct 4, 2019
@primalmotion primalmotion changed the title @primalmotion new: faster push dispatch new: faster push dispatch Oct 4, 2019
@primalmotion

This comment has been minimized.

Copy link
Member Author

commented Oct 4, 2019

/build

@codecov

This comment has been minimized.

Copy link

commented Oct 4, 2019

Codecov Report

Merging #76 into master will increase coverage by 0.48%.
The diff coverage is 80.24%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #76      +/-   ##
==========================================
+ Coverage   88.21%   88.69%   +0.48%     
==========================================
  Files          28       28              
  Lines        2283     2327      +44     
==========================================
+ Hits         2014     2064      +50     
+ Misses        239      233       -6     
  Partials       30       30
Impacted Files Coverage Δ
websocket_server.go 81.95% <80%> (+1.34%) ⬆️
websocket_push_session.go 92.85% <80.64%> (+10.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec4c556...6b50438. Read the comment docs.

@primalmotion

This comment has been minimized.

Copy link
Member Author

commented Oct 4, 2019

/build

@primalmotion

This comment has been minimized.

Copy link
Member Author

commented Oct 4, 2019

/build

1 similar comment
@primalmotion

This comment has been minimized.

Copy link
Member Author

commented Oct 4, 2019

/build

@primalmotion primalmotion merged commit ae99b06 into master Oct 4, 2019
3 of 4 checks passed
3 of 4 checks passed
codecov/patch 80.24% of diff hit (target 88.21%)
Details
built
Details
codecov/project 88.69% (+0.48%) compared to ec4c556
Details
unit-tests
Details
@primalmotion primalmotion deleted the smarter-push branch Oct 4, 2019
primalmotion added a commit that referenced this pull request Oct 4, 2019
This reverts commit ae99b06.
primalmotion added a commit that referenced this pull request Oct 4, 2019
This reverts commit 83824bf.
primalmotion added a commit that referenced this pull request Oct 7, 2019
* Revert "Revert "new: faster push dispatch (#76)""

This reverts commit 83824bf.

* new: enhance the push dispatch handler

* fixed: tests

* doc: added comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.