Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new: push server performance #77

Merged
merged 4 commits into from Oct 7, 2019

Conversation

@primalmotion
Copy link
Member

commented Oct 4, 2019

this reintroduces the previous PR that got reverted and adds what was missing

primalmotion added 2 commits Oct 4, 2019
This reverts commit 83824bf.
@primalmotion primalmotion changed the title new: enhance the push dispatch handler new: push server performances Oct 4, 2019
@primalmotion primalmotion changed the title new: push server performances new: push server performance Oct 4, 2019
@primalmotion

This comment has been minimized.

Copy link
Member Author

commented Oct 4, 2019

/build

@codecov

This comment has been minimized.

Copy link

commented Oct 4, 2019

Codecov Report

Merging #77 into master will increase coverage by 0.3%.
The diff coverage is 77.55%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #77     +/-   ##
=========================================
+ Coverage   88.21%   88.52%   +0.3%     
=========================================
  Files          28       28             
  Lines        2283     2344     +61     
=========================================
+ Hits         2014     2075     +61     
+ Misses        239      238      -1     
- Partials       30       31      +1
Impacted Files Coverage Δ
websocket_server.go 80.63% <76.11%> (+0.02%) ⬆️
websocket_push_session.go 92.85% <80.64%> (+10.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83824bf...c053574. Read the comment docs.

@aporeto-bot

This comment has been minimized.

Copy link

commented Oct 4, 2019

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "new-push",
    "component": "bahamut",
    "pr-id": "77",
    "commit-sha": "f5adeedddd391eaa6d06d575af81e1bf28395336"
  },
  {
    "project": "new-push",
    "component": "backend",
    "pr-id": "585",
    "commit-sha": "e91e63a204278f7780b688fa9ec53dcd409a0ccb"
  }
]
@primalmotion primalmotion merged commit 600445a into master Oct 7, 2019
@primalmotion primalmotion deleted the smarter-push2 branch Oct 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.