Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd support for fine-grained websocket filtering #82
Conversation
-💥 add new method to the 'Session' interface, 'PushConfig', to make it possible to retrieve the current push config active on the session. -🔥 remove usage of deprecated type 'elemental.PushFilter'; replaced with the re-named equivalent 'elemental.PushConfig' - parse the identity filters upon receipt of a 'elemental.PushConfig' to avoid having to parse them on each push event received by the push server - in the event that parsing fails, the socket is closed.
This comment has been minimized.
This comment has been minimized.
/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0
|
This comment has been minimized.
This comment has been minimized.
/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0
|
This comment has been minimized.
This comment has been minimized.
Update
If FYI: @primalmotion |
…socket should be closed based on the error type it returns
aa8254e
to
26fda9e
This comment has been minimized.
This comment has been minimized.
/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0
|
This comment has been minimized.
This comment has been minimized.
/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0
|
This comment has been minimized.
This comment has been minimized.
/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0
|
aaslamin commentedNov 20, 2019
Issue: aporeto-inc/aporeto#1699
This PR:
Session
interface,PushConfig
, to make it possible to retrieve the push config currently active on the session.Note: this was done so that this callback:
elemental.PushFilter
; replaced with the re-named equivalentelemental.PushConfig
Parse the identity filters upon receipt of a
elemental.PushConfig
to avoid having to parse them on each push event received by the push serverTODO:
elemental.PushConfig
from connected client