Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new: added push upstreamer #89

Merged
merged 12 commits into from Mar 11, 2020
Merged

new: added push upstreamer #89

merged 12 commits into from Mar 11, 2020

Conversation

@primalmotion
Copy link
Member

primalmotion commented Mar 11, 2020

This PRs adds a new Gateway Upstreamer based on auto registration through a bahamut.PubSubClient.

The Gateway can use the push.Upstreamer to handle the upstreams, and all services use the push.Notifier to register bahamut start and stop hooks to announce their routes and how to reach them

primalmotion added 10 commits Mar 11, 2020
@codecov

This comment has been minimized.

Copy link

codecov bot commented Mar 11, 2020

Codecov Report

Merging #89 into master will increase coverage by 0.06%.
The diff coverage is 90.39%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #89      +/-   ##
==========================================
+ Coverage   89.68%   89.75%   +0.06%     
==========================================
  Files          36       41       +5     
  Lines        2929     3210     +281     
==========================================
+ Hits         2627     2881     +254     
- Misses        257      274      +17     
- Partials       45       55      +10
Impacted Files Coverage Δ
gateway/upstreamer/push/utils.go 100% <100%> (ø)
gateway/upstreamer/push/options.go 100% <100%> (ø)
gateway/upstreamer/push/services.go 100% <100%> (ø)
gateway/upstreamer/push/notifier.go 63.63% <63.63%> (ø)
gateway/upstreamer/push/upstreamer.go 93.8% <93.8%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cdfe7ea...b7a94f0. Read the comment docs.

@primalmotion primalmotion merged commit 3e80ba6 into master Mar 11, 2020
4 checks passed
4 checks passed
codecov/patch 90.39% of diff hit (target 89.68%)
Details
codecov/project 89.75% (+0.06%) compared to cdfe7ea
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@primalmotion primalmotion deleted the upstreamer branch Mar 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.