Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new: move manipulate.FIlter in elemental #39

Merged
merged 2 commits into from May 2, 2019

Conversation

Projects
None yet
2 participants
@primalmotion
Copy link
Member

commented May 2, 2019

This patch moves the manipulate.Filter to elemental.

This patch is required to allow a deeper understanding of filters, so libraries that are not necessarily using manipulate can use filtering.

The end goal of this move is to allow

  • checking is an elemental.Identifiable matches a filter
  • extracting matching elemental.Identifiable from a elemental.Identifiables list
  • advanced push filtering
@aporeto-bot

This comment has been minimized.

Copy link

commented May 2, 2019

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "elemental-filter",
    "component": "underwater",
    "pr-id": "56",
    "commit-sha": "1c7ec893e0cbf146e871c2cd8da314bdd44aa406"
  },
  {
    "project": "elemental-filter",
    "component": "manipulate",
    "pr-id": "78",
    "commit-sha": "e864ad5fc4afc460449111fba9febf6bcab42172"
  },
  {
    "project": "elemental-filter",
    "component": "elemental",
    "pr-id": "39",
    "commit-sha": "d8b6cdab4942de8c736475b1f8ffe208771f92c5"
  },
  {
    "project": "elemental-filter",
    "component": "backend",
    "pr-id": "384",
    "commit-sha": "591bcc7d94a26ac3fdf15939b350bd06074433a9"
  },
  {
    "project": "elemental-filter",
    "component": "apoctl",
    "pr-id": "178",
    "commit-sha": "dd2346a794fcea4e82b969c85624f6f834990bdd"
  }
]
@codecov

This comment has been minimized.

Copy link

commented May 2, 2019

Codecov Report

Merging #39 into master will decrease coverage by 2.78%.
The diff coverage is 92.15%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #39      +/-   ##
==========================================
- Coverage   99.81%   97.02%   -2.79%     
==========================================
  Files          14       17       +3     
  Lines        1068     1680     +612     
==========================================
+ Hits         1066     1630     +564     
- Misses          1       28      +27     
- Partials        1       22      +21
Impacted Files Coverage Δ
filterparser.go 86.99% <86.99%> (ø)
filterscanner.go 95.12% <95.12%> (ø)
filters.go 99.03% <99.03%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68629ef...1b4e131. Read the comment docs.

@primalmotion

This comment has been minimized.

Copy link
Member Author

commented May 2, 2019

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "elemental-filter",
    "component": "underwater",
    "pr-id": "56",
    "commit-sha": "1c7ec893e0cbf146e871c2cd8da314bdd44aa406"
  },
  {
    "project": "elemental-filter",
    "component": "manipulate",
    "pr-id": "78",
    "commit-sha": "a5840d091c3886b0681b927fb8635670bc0d93dc"
  },
  {
    "project": "elemental-filter",
    "component": "backend",
    "pr-id": "384",
    "commit-sha": "591bcc7d94a26ac3fdf15939b350bd06074433a9"
  },
  {
    "project": "elemental-filter",
    "component": "apoctl",
    "pr-id": "178",
    "commit-sha": "dd2346a794fcea4e82b969c85624f6f834990bdd"
  },
  {
    "project": "elemental-filter",
    "component": "elemental",
    "pr-id": "39",
    "commit-sha": "1b4e131f2ff18267fe60ce889cafe338047d0ed2"
  }
]

@primalmotion primalmotion merged commit b2e91a6 into master May 2, 2019

4 of 6 checks passed

codecov/patch 92.15% of diff hit (target 99.81%)
Details
codecov/project 97.02% (-2.79%) compared to 68629ef
Details
built
Details
functional-tests Submitter: reason: . functional-tests set to success
Details
functional-tests-trigger Submitter: reason: . functional-tests-trigger set to success
Details
unit-tests
Details

@primalmotion primalmotion deleted the elemental-filter branch May 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.