Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new: better support for custom mime-types #70

Merged
merged 1 commit into from Mar 20, 2020
Merged

new: better support for custom mime-types #70

merged 1 commit into from Mar 20, 2020

Conversation

@primalmotion
Copy link
Member

primalmotion commented Mar 19, 2020

Do not read the body or try to decode the data when content-type or accept header is set to be one of the registered custom mime type.

This means the Data property of elemental.Request will not be populated. The handler must deal with reading the body from the internal http.Request.

Do not read the body or try to decode the data when content-type or accept header is set to be one of the registered custom mime type.

This means the Data property of elemental.Request will not be populated. The handler must deal with reading the body from the internal http.Request.
@codecov

This comment has been minimized.

Copy link

codecov bot commented Mar 19, 2020

Codecov Report

Merging #70 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #70      +/-   ##
==========================================
+ Coverage   83.84%   83.88%   +0.04%     
==========================================
  Files          24       24              
  Lines        2389     2395       +6     
==========================================
+ Hits         2003     2009       +6     
  Misses        358      358              
  Partials       28       28
Impacted Files Coverage Δ
request.go 100% <100%> (ø) ⬆️
encoding.go 98.18% <100%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c9a00e...5d54853. Read the comment docs.

@aporeto-bot

This comment has been minimized.

Copy link

aporeto-bot commented Mar 19, 2020

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "file-upload",
    "component": "elemental",
    "pr-id": "70",
    "commit-sha": "5d54853848f8caf5c69d422d0446cbcbcbe1b300",
    "pipeline": "master"
  },
  {
    "project": "file-upload",
    "component": "gaia",
    "pr-id": "462",
    "commit-sha": "646cf77397c603a4f3f4d2c35aba606e21da076b",
    "pipeline": "master"
  },
  {
    "project": "file-upload",
    "component": "bahamut",
    "pr-id": "91",
    "commit-sha": "b69c80ec28b2441f4c54f98632a75eefcda3a01a",
    "pipeline": "master"
  },
  {
    "project": "file-upload",
    "component": "backend",
    "pr-id": "711",
    "commit-sha": "be0e84a26e973708c8838c33ec6e52d83ec10bed",
    "pipeline": "master"
  }
]
@aporeto-bot

This comment has been minimized.

Copy link

aporeto-bot commented Mar 19, 2020

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "file-upload",
    "component": "elemental",
    "pr-id": "70",
    "commit-sha": "5d54853848f8caf5c69d422d0446cbcbcbe1b300",
    "pipeline": "master"
  },
  {
    "project": "file-upload",
    "component": "gaia",
    "pr-id": "462",
    "commit-sha": "646cf77397c603a4f3f4d2c35aba606e21da076b",
    "pipeline": "master"
  },
  {
    "project": "file-upload",
    "component": "bahamut",
    "pr-id": "91",
    "commit-sha": "a684e9333f1a5bb129f486f51fad9de3a507e915",
    "pipeline": "master"
  },
  {
    "project": "file-upload",
    "component": "backend",
    "pr-id": "711",
    "commit-sha": "5c1c63d7f905d4274979ae6b6cbc39ba7fe6faf8",
    "pipeline": "master"
  }
]
@aporeto-bot

This comment has been minimized.

Copy link

aporeto-bot commented Mar 19, 2020

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "file-upload",
    "component": "gaia",
    "pr-id": "462",
    "commit-sha": "53557cf803db32d206efc676a4f852733cac1b56",
    "pipeline": "master"
  },
  {
    "project": "file-upload",
    "component": "bahamut",
    "pr-id": "91",
    "commit-sha": "a684e9333f1a5bb129f486f51fad9de3a507e915",
    "pipeline": "master"
  },
  {
    "project": "file-upload",
    "component": "backend",
    "pr-id": "711",
    "commit-sha": "836c3b9a1ddceeaffd0157e70b0c254ae35c70b1",
    "pipeline": "master"
  },
  {
    "project": "file-upload",
    "component": "elemental",
    "pr-id": "70",
    "commit-sha": "5d54853848f8caf5c69d422d0446cbcbcbe1b300",
    "pipeline": "master"
  }
]
@aporeto-bot

This comment has been minimized.

Copy link

aporeto-bot commented Mar 19, 2020

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "file-upload",
    "component": "elemental",
    "pr-id": "70",
    "commit-sha": "5d54853848f8caf5c69d422d0446cbcbcbe1b300",
    "pipeline": "master"
  },
  {
    "project": "file-upload",
    "component": "gaia",
    "pr-id": "462",
    "commit-sha": "53557cf803db32d206efc676a4f852733cac1b56",
    "pipeline": "master"
  },
  {
    "project": "file-upload",
    "component": "bahamut",
    "pr-id": "91",
    "commit-sha": "a684e9333f1a5bb129f486f51fad9de3a507e915",
    "pipeline": "master"
  },
  {
    "project": "file-upload",
    "component": "backend",
    "pr-id": "711",
    "commit-sha": "c0af7c4f9b7edb4175684454c022f5432e2b4a49",
    "pipeline": "master"
  }
]
@aporeto-bot

This comment has been minimized.

Copy link

aporeto-bot commented Mar 19, 2020

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "file-upload",
    "component": "elemental",
    "pr-id": "70",
    "commit-sha": "5d54853848f8caf5c69d422d0446cbcbcbe1b300",
    "pipeline": "master"
  },
  {
    "project": "file-upload",
    "component": "gaia",
    "pr-id": "462",
    "commit-sha": "27d70c88263d6c2c9f8e5e7407f2838864ed65df",
    "pipeline": "master"
  },
  {
    "project": "file-upload",
    "component": "bahamut",
    "pr-id": "91",
    "commit-sha": "a684e9333f1a5bb129f486f51fad9de3a507e915",
    "pipeline": "master"
  },
  {
    "project": "file-upload",
    "component": "backend",
    "pr-id": "711",
    "commit-sha": "9743f2c9117c5bca0bc8e70c1051620acb140590",
    "pipeline": "master"
  }
]
@aporeto-bot

This comment has been minimized.

Copy link

aporeto-bot commented Mar 19, 2020

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "file-upload",
    "component": "elemental",
    "pr-id": "70",
    "commit-sha": "5d54853848f8caf5c69d422d0446cbcbcbe1b300",
    "pipeline": "master"
  },
  {
    "project": "file-upload",
    "component": "gaia",
    "pr-id": "462",
    "commit-sha": "57da388d4faa48f12cc8906d3ceec8e8c329c5c7",
    "pipeline": "master"
  },
  {
    "project": "file-upload",
    "component": "bahamut",
    "pr-id": "91",
    "commit-sha": "a684e9333f1a5bb129f486f51fad9de3a507e915",
    "pipeline": "master"
  },
  {
    "project": "file-upload",
    "component": "backend",
    "pr-id": "711",
    "commit-sha": "9743f2c9117c5bca0bc8e70c1051620acb140590",
    "pipeline": "master"
  }
]
@t00f

This comment has been minimized.

Copy link
Member

t00f commented Mar 20, 2020

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "file-upload",
    "component": "elemental",
    "pr-id": "70",
    "commit-sha": "5d54853848f8caf5c69d422d0446cbcbcbe1b300",
    "pipeline": "master"
  },
  {
    "project": "file-upload",
    "component": "gaia",
    "pr-id": "462",
    "commit-sha": "57bd4044e7d8fa58f61954e977131f3c637ebfc9",
    "pipeline": "master"
  },
  {
    "project": "file-upload",
    "component": "bahamut",
    "pr-id": "91",
    "commit-sha": "a684e9333f1a5bb129f486f51fad9de3a507e915",
    "pipeline": "master"
  },
  {
    "project": "file-upload",
    "component": "backend",
    "pr-id": "711",
    "commit-sha": "9743f2c9117c5bca0bc8e70c1051620acb140590",
    "pipeline": "master"
  }
]
@t00f t00f merged commit 9b32dc1 into master Mar 20, 2020
6 checks passed
6 checks passed
codecov/patch 100% of diff hit (target 83.84%)
Details
codecov/project 83.88% (+0.04%) compared to 6c9a00e
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
functional-tests Submitter: reason: . functional-tests set to success
Details
functional-tests-trigger Submitter: reason: . functional-tests-trigger set to success
Details
@t00f t00f deleted the better-custom-mime branch Mar 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.