Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make mTLS optional when defining a hook #317

Merged
merged 6 commits into from Jun 18, 2019
Commits on Jun 3, 2019
  1. edit: make mTLS fields optional on hookpolicy model

    aaslamin committed May 8, 2019
    Signed-off-by: Amir Aslaminejad <amir.a@aporeto.com>
  2. fix: typo in hookpolicy endpoint attribute description

    aaslamin committed May 8, 2019
    Signed-off-by: Amir Aslaminejad <amir.a@aporeto.com>
  3. new: add validation helper for validating a grouping of related attri…

    aaslamin committed May 9, 2019
    …butes - useful for when you need to check if a group of optional attributes are either all provided or not at all
    
    new: add custom validation on hookpolicies model for the validation of the now optional client mTLS attributes - clientCertificate & clientCertificateKey - if either one is provided, they now must BOTH be provided
    
    Signed-off-by: Amir Aslaminejad <amir.a@aporeto.com>
  4. docs: update description on clientCertificate & clientCertificateKey …

    aaslamin committed May 9, 2019
    …attributes to when they should be provided
    
    Signed-off-by: Amir Aslaminejad <amir.a@aporeto.com>
  5. fix: remove unnecessary allocation of booleans from validation helper

    aaslamin committed May 9, 2019
    Signed-off-by: Amir Aslaminejad <amir.a@aporeto.com>
You can’t perform that action at this time.