Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removed LDAP properties in Account #333

Merged
merged 1 commit into from Jun 7, 2019

Conversation

Projects
None yet
3 participants
@t00f
Copy link
Member

commented Jun 4, 2019

LDAP properties are now coming from the LDAPProvider. We can safely remove the account properties. Migration will use the old model.

@t00f t00f requested review from ericrpowers and primalmotion and removed request for ericrpowers Jun 4, 2019

@aporeto-bot

This comment has been minimized.

Copy link
Contributor

commented Jun 5, 2019

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "cleanup_account_spec",
    "component": "apocheck",
    "pr-id": "40",
    "commit-sha": "f39496aff64311785d83eb54e2715fee99c8f3a1"
  },
  {
    "project": "cleanup_account_spec",
    "component": "gaia",
    "pr-id": "333",
    "commit-sha": "68df0e5ec96a5151ae80708892b1fd456c4e1a1b"
  },
  {
    "project": "cleanup_account_spec",
    "component": "backend",
    "pr-id": "414",
    "commit-sha": "3e30cf0c2418fa48606c8e0cad1cfb8caa1c4088"
  }
]
@aporeto-bot

This comment has been minimized.

Copy link
Contributor

commented Jun 5, 2019

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "cleanup_account_spec",
    "component": "apocheck",
    "pr-id": "40",
    "commit-sha": "f39496aff64311785d83eb54e2715fee99c8f3a1"
  },
  {
    "project": "cleanup_account_spec",
    "component": "gaia",
    "pr-id": "333",
    "commit-sha": "68df0e5ec96a5151ae80708892b1fd456c4e1a1b"
  },
  {
    "project": "cleanup_account_spec",
    "component": "backend",
    "pr-id": "414",
    "commit-sha": "86b849a7fab103feb34467157ca6a2114e4efbfc"
  }
]
@aporeto-bot

This comment has been minimized.

Copy link
Contributor

commented Jun 5, 2019

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "cleanup_account_spec",
    "component": "apocheck",
    "pr-id": "40",
    "commit-sha": "f39496aff64311785d83eb54e2715fee99c8f3a1"
  },
  {
    "project": "cleanup_account_spec",
    "component": "gaia",
    "pr-id": "333",
    "commit-sha": "68df0e5ec96a5151ae80708892b1fd456c4e1a1b"
  },
  {
    "project": "cleanup_account_spec",
    "component": "backend",
    "pr-id": "414",
    "commit-sha": "2ae7fdda6af65736b21d18b293ceb2a256626dfd"
  }
]

@t00f t00f merged commit 6e01d72 into master Jun 7, 2019

4 checks passed

built
Details
functional-tests Submitter: reason: . functional-tests set to success
Details
functional-tests-trigger Submitter: reason: . functional-tests-trigger set to success
Details
unit-tests
Details

@t00f t00f deleted the cleanup_account_spec branch Jun 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.