Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new: add a property to tell which identity the recipes will attempt t… #335

Merged
merged 5 commits into from Jun 12, 2019

Conversation

Projects
None yet
2 participants
@t00f
Copy link
Member

commented Jun 7, 2019

Adding a new property targetIdentities so we can check what are the authorizations the user will need to have to access this recipe.

@t00f

This comment has been minimized.

Copy link
Member Author

commented Jun 7, 2019

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "add_recipe_targetIdentities",
    "component": "backend",
    "pr-id": "421",
    "commit-sha": "ae2fd93b0b5de4c51dec879d8eaedeee26fc4c89"
  },
  {
    "project": "add_recipe_targetIdentities",
    "component": "gaia",
    "pr-id": "335",
    "commit-sha": "1ebe62e0971094bb41f23cbfcea23a229534c719"
  }
]
@t00f

This comment has been minimized.

Copy link
Member Author

commented Jun 8, 2019

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "add_recipe_targetIdentities",
    "component": "backend",
    "pr-id": "421",
    "commit-sha": "9ad2b4131bcb87a8192aee93dbb023699b9a135e"
  },
  {
    "project": "add_recipe_targetIdentities",
    "component": "gaia",
    "pr-id": "335",
    "commit-sha": "1ebe62e0971094bb41f23cbfcea23a229534c719"
  }
]
@t00f

This comment has been minimized.

Copy link
Member Author

commented Jun 8, 2019

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "add_recipe_targetIdentities",
    "component": "backend",
    "pr-id": "421",
    "commit-sha": "9ad2b4131bcb87a8192aee93dbb023699b9a135e"
  },
  {
    "project": "add_recipe_targetIdentities",
    "component": "gaia",
    "pr-id": "335",
    "commit-sha": "8dbe92ee4f5f9ed0e811c78c8d9647e3ba821daf"
  }
]
@t00f

This comment has been minimized.

Copy link
Member Author

commented Jun 9, 2019

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "add_recipe_targetIdentities",
    "component": "backend",
    "pr-id": "421",
    "commit-sha": "db61fbd69a4eced929332b7a8835550e8e32f62a"
  },
  {
    "project": "add_recipe_targetIdentities",
    "component": "gaia",
    "pr-id": "335",
    "commit-sha": "8dbe92ee4f5f9ed0e811c78c8d9647e3ba821daf"
  }
]

@t00f t00f requested a review from primalmotion Jun 10, 2019

@@ -88,6 +88,17 @@ attributes:
exposed: true
stored: true

- name: targetIdentities

This comment has been minimized.

Copy link
@primalmotion

primalmotion Jun 10, 2019

Member

Not stored?

t00f added some commits Jun 10, 2019

@t00f

This comment has been minimized.

Copy link
Member Author

commented Jun 12, 2019

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "add_recipe_targetIdentities",
    "component": "gaia",
    "pr-id": "335",
    "commit-sha": "0de1a906dd64be32f0863dcc26d318e1f423e20b"
  },
  {
    "project": "add_recipe_targetIdentities",
    "component": "backend",
    "pr-id": "421",
    "commit-sha": "0d831a364f55f963a535723ad75775243e8ed915"
  }
]

@t00f t00f merged commit 688d251 into master Jun 12, 2019

2 checks passed

built
Details
unit-tests
Details

@t00f t00f deleted the add_recipe_targetIdentities branch Jun 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.