Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new: add a new property for ports matching policies #336

Merged
merged 14 commits into from Jun 11, 2019

Conversation

Projects
None yet
3 participants
@sibicramesh
Copy link
Member

commented Jun 8, 2019

--> Property that holds protocol/port pair.

Show resolved Hide resolved specs/networkaccesspolicy.spec Outdated
Show resolved Hide resolved specs/_validation.mapping Outdated
Show resolved Hide resolved custom_validations.go Outdated
Show resolved Hide resolved custom_validations.go Outdated
Show resolved Hide resolved specs/_validation.mapping Outdated
Show resolved Hide resolved custom_validations.go Outdated
@sibicramesh

This comment has been minimized.

Copy link
Member Author

commented Jun 11, 2019

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "",
    "component": "gaia",
    "pr-id": "336",
    "commit-sha": "72203ab687eb3279d9d9a00be41c497a9e313bf6"
  }
]

@sibicramesh sibicramesh marked this pull request as ready for review Jun 11, 2019

@sibicramesh sibicramesh added ready and removed in progress labels Jun 11, 2019

@sibicramesh

This comment has been minimized.

Copy link
Member Author

commented Jun 11, 2019

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "ports-matching-policies",
    "component": "underwater",
    "pr-id": "62",
    "commit-sha": "5792f905a7f2125fadf80e9bd6dd72f5c77ce9c9"
  },
  {
    "project": "ports-matching-policies",
    "component": "gaia",
    "pr-id": "336",
    "commit-sha": "b8fd8e794f7b3e53e9741734cf5fd75d082cad4e"
  },
  {
    "project": "ports-matching-policies",
    "component": "enforcerd",
    "pr-id": "1230",
    "commit-sha": "36a887ac1e9e7c74b49a65603729ff053d01c3ed"
  },
  {
    "project": "ports-matching-policies",
    "component": "trireme-lib",
    "pr-id": "814",
    "commit-sha": "f41ccd125cc5f7ab29a9674f4900404ce728229b"
  }
]
@dstiliadis
Copy link
Member

left a comment

See inline.

@sibicramesh sibicramesh requested a review from dstiliadis Jun 11, 2019

@sibicramesh

This comment has been minimized.

Copy link
Member Author

commented Jun 11, 2019

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "ports-matching-policies",
    "component": "gaia",
    "pr-id": "336",
    "commit-sha": "b8fd8e794f7b3e53e9741734cf5fd75d082cad4e"
  },
  {
    "project": "ports-matching-policies",
    "component": "enforcerd",
    "pr-id": "1230",
    "commit-sha": "2b71e836f3f0f48d712bc10da71789a23d79d3ef"
  },
  {
    "project": "ports-matching-policies",
    "component": "trireme-lib",
    "pr-id": "814",
    "commit-sha": "27c5d18df6e0ded3c06bb3a81d12fdd79677ab82"
  },
  {
    "project": "ports-matching-policies",
    "component": "underwater",
    "pr-id": "62",
    "commit-sha": "5792f905a7f2125fadf80e9bd6dd72f5c77ce9c9"
  }
]
Show resolved Hide resolved constants/constants.go Outdated

@sibicramesh sibicramesh requested a review from primalmotion Jun 11, 2019

@sibicramesh

This comment has been minimized.

Copy link
Member Author

commented Jun 11, 2019

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "ports-matching-policies",
    "component": "underwater",
    "pr-id": "62",
    "commit-sha": "5792f905a7f2125fadf80e9bd6dd72f5c77ce9c9"
  },
  {
    "project": "ports-matching-policies",
    "component": "gaia",
    "pr-id": "336",
    "commit-sha": "b843a6d1a48c2614a1cc9ce3ba6afc36d90243e8"
  },
  {
    "project": "ports-matching-policies",
    "component": "enforcerd",
    "pr-id": "1230",
    "commit-sha": "2c52488e35c747ef92660cab6e0727e6fec2bc0d"
  },
  {
    "project": "ports-matching-policies",
    "component": "trireme-lib",
    "pr-id": "814",
    "commit-sha": "27c5d18df6e0ded3c06bb3a81d12fdd79677ab82"
  }
]

@sibicramesh sibicramesh merged commit 4bedd1c into master Jun 11, 2019

2 checks passed

built
Details
unit-tests
Details

@sibicramesh sibicramesh deleted the ports branch Jun 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.