Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow upto 128 characters for hostservice name #374

Merged
merged 2 commits into from Aug 6, 2019

Conversation

@sibicramesh
Copy link
Member

commented Aug 1, 2019

--> Go easy on the regex and allow upto 128 chars.
--> project

@sibicramesh

This comment has been minimized.

Copy link
Member Author

commented Aug 1, 2019

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "hs-name",
    "component": "enforcerd",
    "pr-id": "1303",
    "commit-sha": "e9d62252ce8beaf64402a882caeb9f7c62574df5"
  },
  {
    "project": "hs-name",
    "component": "backend",
    "pr-id": "488",
    "commit-sha": "acda747bd498dd7c2271abece3cefafe9bcb304e"
  },
  {
    "project": "hs-name",
    "component": "gaia",
    "pr-id": "374",
    "commit-sha": "bb7b4b2891a29bc643e50d3a1af3cb9cdd6662d2"
  }
]
@sibicramesh

This comment has been minimized.

Copy link
Member Author

commented Aug 2, 2019

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "hs-name",
    "component": "backend",
    "pr-id": "488",
    "commit-sha": "052534c728dfd7915dc7d9b62a914d74fa809659"
  },
  {
    "project": "hs-name",
    "component": "gaia",
    "pr-id": "374",
    "commit-sha": "bb7b4b2891a29bc643e50d3a1af3cb9cdd6662d2"
  },
  {
    "project": "hs-name",
    "component": "enforcerd",
    "pr-id": "1303",
    "commit-sha": "e9d62252ce8beaf64402a882caeb9f7c62574df5"
  }
]
@sibicramesh

This comment has been minimized.

Copy link
Member Author

commented Aug 2, 2019

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "hs-name",
    "component": "enforcerd",
    "pr-id": "1303",
    "commit-sha": "e9d62252ce8beaf64402a882caeb9f7c62574df5"
  },
  {
    "project": "hs-name",
    "component": "backend",
    "pr-id": "488",
    "commit-sha": "24079d4890f566baede8418682f93c9b86b069e7"
  },
  {
    "project": "hs-name",
    "component": "gaia",
    "pr-id": "374",
    "commit-sha": "bb7b4b2891a29bc643e50d3a1af3cb9cdd6662d2"
  }
]
@sibicramesh

This comment has been minimized.

Copy link
Member Author

commented Aug 2, 2019

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "hs-name",
    "component": "backend",
    "pr-id": "488",
    "commit-sha": "e720330a9eb2297db02afe10c8f47ba4f6210391"
  },
  {
    "project": "hs-name",
    "component": "gaia",
    "pr-id": "374",
    "commit-sha": "bb7b4b2891a29bc643e50d3a1af3cb9cdd6662d2"
  },
  {
    "project": "hs-name",
    "component": "enforcerd",
    "pr-id": "1303",
    "commit-sha": "e9d62252ce8beaf64402a882caeb9f7c62574df5"
  }
]
@sibicramesh

This comment has been minimized.

Copy link
Member Author

commented Aug 2, 2019

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "hs-name",
    "component": "gaia",
    "pr-id": "374",
    "commit-sha": "906fb57d4e2563ed202203fc74057d8a007d6fa1"
  },
  {
    "project": "hs-name",
    "component": "enforcerd",
    "pr-id": "1303",
    "commit-sha": "0f77bd59841981849f3f6235070185d753f209a5"
  },
  {
    "project": "hs-name",
    "component": "backend",
    "pr-id": "488",
    "commit-sha": "f0f6eacbafe194f993bb354d0024cb00a1f5e12c"
  }
]
@sibicramesh

This comment has been minimized.

Copy link
Member Author

commented Aug 5, 2019

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "hs-name",
    "component": "enforcerd",
    "pr-id": "1303",
    "commit-sha": "97b92727d4ac27a22415620dff8e0d622ecec327"
  },
  {
    "project": "hs-name",
    "component": "backend",
    "pr-id": "488",
    "commit-sha": "6463dbb438f04ad0a1b3380b97b2eb5bbd6d34bb"
  },
  {
    "project": "hs-name",
    "component": "gaia",
    "pr-id": "374",
    "commit-sha": "906fb57d4e2563ed202203fc74057d8a007d6fa1"
  }
]

@sibicramesh sibicramesh merged commit 079c3d3 into master Aug 6, 2019

4 checks passed

built
Details
functional-tests Submitter: reason: . functional-tests set to success
Details
functional-tests-trigger Submitter: reason: . functional-tests-trigger set to success
Details
unit-tests
Details

@sibicramesh sibicramesh deleted the remove-const branch Aug 6, 2019

sibicramesh added a commit that referenced this pull request Aug 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.