Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add deploymendMode as a recipe option #404

Open
wants to merge 8 commits into
base: master
from

Conversation

@t00f
Copy link
Member

commented Sep 6, 2019

Adds a deploymentMode in the recipe options:

  • Unrestricted = no constraint
  • Unique = Unique in the current namespace and its sub namespaces
  • NamespaceUnique = Unique in the current namespace only

Fixes aporeto-inc/aporeto#1860
Project: https://github.com/orgs/aporeto-inc/projects/623

@@ -20,3 +20,14 @@ attributes:
- JSON
- YAML
default_value: JSON

- name: deploymentMode
description: Indicates if the recipe can be run multiple time.

This comment has been minimized.

Copy link
@primalmotion

primalmotion Sep 6, 2019

Member

can you explain what each value means?

This comment has been minimized.

Copy link
@primalmotion

primalmotion Sep 6, 2019

Member

actually this should be in the recipe itself,Options are for api users, not the backend

This comment has been minimized.

Copy link
@t00f

t00f Sep 6, 2019

Author Member

Yes, I kinda hesitated which is why I made the PRs live :D Will do !

@@ -20,3 +20,14 @@ attributes:
- JSON
- YAML
default_value: JSON

- name: deploymentMode
description: Indicates if the recipe can be run multiple time.

This comment has been minimized.

Copy link
@primalmotion

primalmotion Sep 6, 2019

Member

actually this should be in the recipe itself,Options are for api users, not the backend

t00f added 3 commits Sep 10, 2019
@t00f

This comment has been minimized.

Copy link
Member Author

commented Sep 12, 2019

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "fix_1860",
    "component": "gaia",
    "pr-id": "404",
    "commit-sha": "7c15a11fa89aabc0ee28e717dacf99410ed6b988"
  },
  {
    "project": "fix_1860",
    "component": "backend",
    "pr-id": "544",
    "commit-sha": "39077dc42813b83632034fb3cda1d6d7cee55f3d"
  },
  {
    "project": "fix_1860",
    "component": "clad",
    "pr-id": "1294",
    "commit-sha": "36f175413c964aa418e796f1fd1595f1989cf621"
  }
]
1 similar comment
@t00f

This comment has been minimized.

Copy link
Member Author

commented Sep 13, 2019

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "fix_1860",
    "component": "gaia",
    "pr-id": "404",
    "commit-sha": "7c15a11fa89aabc0ee28e717dacf99410ed6b988"
  },
  {
    "project": "fix_1860",
    "component": "backend",
    "pr-id": "544",
    "commit-sha": "39077dc42813b83632034fb3cda1d6d7cee55f3d"
  },
  {
    "project": "fix_1860",
    "component": "clad",
    "pr-id": "1294",
    "commit-sha": "36f175413c964aa418e796f1fd1595f1989cf621"
  }
]
t00f added 2 commits Sep 13, 2019
@t00f

This comment has been minimized.

Copy link
Member Author

commented Sep 13, 2019

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "fix_1860",
    "component": "clad",
    "pr-id": "1294",
    "commit-sha": "650f6ca11be794801df20a66414fe0f194e039fe"
  },
  {
    "project": "fix_1860",
    "component": "gaia",
    "pr-id": "404",
    "commit-sha": "b17439148d09e8d131bc96a7385f9ef95eff53d3"
  },
  {
    "project": "fix_1860",
    "component": "backend",
    "pr-id": "544",
    "commit-sha": "53769d4a04218c6c8d2fd553187337b03574ff8b"
  }
]
t00f added 2 commits Sep 13, 2019
@t00f

This comment has been minimized.

Copy link
Member Author

commented Sep 14, 2019

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "fix_1860",
    "component": "clad",
    "pr-id": "1294",
    "commit-sha": "6118b12301b085c1d94ee6109bdd20f567127f0b"
  },
  {
    "project": "fix_1860",
    "component": "gaia",
    "pr-id": "404",
    "commit-sha": "340e187fbd55ef51e395121240176f8dc6911de8"
  },
  {
    "project": "fix_1860",
    "component": "backend",
    "pr-id": "544",
    "commit-sha": "45b101a709a920943132eb41d9f2a9298c364176"
  }
]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.