Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new: move Filtering out of elemental #78

Merged
merged 3 commits into from May 2, 2019

Conversation

Projects
None yet
2 participants
@primalmotion
Copy link
Member

commented May 2, 2019

This moves manipulate.Filter to elemental and provides type mappings for backward compatibility.

see: aporeto-inc/elemental#39

primalmotion added some commits May 2, 2019

@aporeto-bot

This comment has been minimized.

Copy link

commented May 2, 2019

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "elemental-filter",
    "component": "underwater",
    "pr-id": "56",
    "commit-sha": "1c7ec893e0cbf146e871c2cd8da314bdd44aa406"
  },
  {
    "project": "elemental-filter",
    "component": "manipulate",
    "pr-id": "78",
    "commit-sha": "e864ad5fc4afc460449111fba9febf6bcab42172"
  },
  {
    "project": "elemental-filter",
    "component": "elemental",
    "pr-id": "39",
    "commit-sha": "d8b6cdab4942de8c736475b1f8ffe208771f92c5"
  },
  {
    "project": "elemental-filter",
    "component": "backend",
    "pr-id": "384",
    "commit-sha": "591bcc7d94a26ac3fdf15939b350bd06074433a9"
  },
  {
    "project": "elemental-filter",
    "component": "apoctl",
    "pr-id": "178",
    "commit-sha": "dd2346a794fcea4e82b969c85624f6f834990bdd"
  }
]
@primalmotion

This comment has been minimized.

Copy link
Member Author

commented May 2, 2019

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "elemental-filter",
    "component": "backend",
    "pr-id": "384",
    "commit-sha": "591bcc7d94a26ac3fdf15939b350bd06074433a9"
  },
  {
    "project": "elemental-filter",
    "component": "apoctl",
    "pr-id": "178",
    "commit-sha": "dd2346a794fcea4e82b969c85624f6f834990bdd"
  },
  {
    "project": "elemental-filter",
    "component": "manipulate",
    "pr-id": "78",
    "commit-sha": "a5840d091c3886b0681b927fb8635670bc0d93dc"
  },
  {
    "project": "elemental-filter",
    "component": "underwater",
    "pr-id": "56",
    "commit-sha": "1c7ec893e0cbf146e871c2cd8da314bdd44aa406"
  },
  {
    "project": "elemental-filter",
    "component": "elemental",
    "pr-id": "39",
    "commit-sha": "d8b6cdab4942de8c736475b1f8ffe208771f92c5"
  }
]
@codecov

This comment has been minimized.

Copy link

commented May 2, 2019

Codecov Report

Merging #78 into master will decrease coverage by 3.64%.
The diff coverage is 65.78%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #78      +/-   ##
==========================================
- Coverage   77.44%   73.79%   -3.65%     
==========================================
  Files          34       32       -2     
  Lines        2886     2286     -600     
==========================================
- Hits         2235     1687     -548     
+ Misses        560      530      -30     
+ Partials       91       69      -22
Impacted Files Coverage Δ
manipmongo/helpers.go 0% <0%> (ø) ⬆️
filter.go 0% <0%> (ø)
maniphttp/internal/compiler/filter.go 100% <100%> (ø) ⬆️
manipmongo/internal/compiler/filter.go 94.8% <100%> (ø) ⬆️
options.go 100% <100%> (ø) ⬆️
manipmemory/manipulator.go 87.43% <100%> (ø) ⬆️
context.go 93.1% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f16f6b...a5840d0. Read the comment docs.

@primalmotion primalmotion merged commit c51fa95 into master May 2, 2019

4 of 6 checks passed

codecov/patch 65.78% of diff hit (target 77.44%)
Details
codecov/project 73.79% (-3.65%) compared to 8f16f6b
Details
built
Details
functional-tests Submitter: reason: . functional-tests set to success
Details
functional-tests-trigger Submitter: reason: . functional-tests-trigger set to success
Details
unit-tests
Details

@primalmotion primalmotion deleted the elemental-filter branch May 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.