Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed: panic in certain circumstances #86

Merged
merged 1 commit into from Jun 5, 2019

Conversation

Projects
None yet
1 participant
@primalmotion
Copy link
Member

commented Jun 4, 2019

This patch should fix the case where send
function can return a nil error and a nil
response when retrying auth auth is while the context just got expired.

fixed: panic in certain circumstances
This patch should fix the case where send
function can return a nil error and a nil
response when retrying auth auth is while the context just got expired.
@primalmotion

This comment has been minimized.

Copy link
Member Author

commented Jun 4, 2019

/build

@codecov

This comment has been minimized.

Copy link

commented Jun 4, 2019

Codecov Report

Merging #86 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #86   +/-   ##
=======================================
  Coverage   77.45%   77.45%           
=======================================
  Files          34       34           
  Lines        2440     2440           
=======================================
  Hits         1890     1890           
  Misses        488      488           
  Partials       62       62
Impacted Files Coverage Δ
maniphttp/manipulator.go 97.01% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 527457e...f6e7cac. Read the comment docs.

@primalmotion primalmotion merged commit d10d547 into master Jun 5, 2019

4 checks passed

built
Details
codecov/patch 100% of diff hit (target 77.45%)
Details
codecov/project 77.45% (+0%) compared to 527457e
Details
unit-tests
Details

@primalmotion primalmotion deleted the fixed-panic-in-certain-circumstances branch Jun 5, 2019

@primalmotion primalmotion restored the fixed-panic-in-certain-circumstances branch Jun 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.