Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new/manipmongo: better sharding interface #87

Merged
merged 10 commits into from Jun 12, 2019

Conversation

Projects
None yet
3 participants
@primalmotion
Copy link
Member

commented Jun 10, 2019

No description provided.

primalmotion added some commits Jun 6, 2019

new/manipmongo: add helper Ensureindexes()
Works like CreateIndexes, but will delete and recreate
if it gets the error telling options changed

@primalmotion primalmotion changed the title new: added option to force a read filter new/manipmongo: better sharding interface Jun 10, 2019

@aporeto-bot

This comment has been minimized.

Copy link

commented Jun 10, 2019

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "sharding-2",
    "component": "gaia",
    "pr-id": "339",
    "commit-sha": "a6fc6cdb33be1f02a7da25576ce676142ccd0b3e"
  },
  {
    "project": "sharding-2",
    "component": "manipulate",
    "pr-id": "87",
    "commit-sha": "c0ae5c2fc8a211e348dd8a57fa46c69a6e659846"
  },
  {
    "project": "sharding-2",
    "component": "backend",
    "pr-id": "424",
    "commit-sha": "d2bccba9373f6168f67792f286323e510257434e"
  }
]
@aporeto-bot

This comment has been minimized.

Copy link

commented Jun 10, 2019

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "sharding-2",
    "component": "manipulate",
    "pr-id": "87",
    "commit-sha": "0ce78e0f649eb6e62a8027a040c22e2e663cec96"
  },
  {
    "project": "sharding-2",
    "component": "backend",
    "pr-id": "424",
    "commit-sha": "3c505a8536b529871e2c685b72d10a4d82c94eb0"
  },
  {
    "project": "sharding-2",
    "component": "gaia",
    "pr-id": "339",
    "commit-sha": "4c2fde7b96c5512e392716f082544efbaff9ccde"
  }
]
@codecov

This comment has been minimized.

Copy link

commented Jun 10, 2019

Codecov Report

Merging #87 into master will decrease coverage by 0.19%.
The diff coverage is 15.62%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #87     +/-   ##
=========================================
- Coverage   77.52%   77.32%   -0.2%     
=========================================
  Files          34       34             
  Lines        2447     2501     +54     
=========================================
+ Hits         1897     1934     +37     
- Misses        488      505     +17     
  Partials       62       62
Impacted Files Coverage Δ
manipmongo/manipulator.go 0% <0%> (ø) ⬆️
manipmongo/options.go 100% <100%> (ø) ⬆️
manipmongo/helpers.go 53.27% <31.81%> (+27.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 009a99a...26ecf1b. Read the comment docs.

@aporeto-bot

This comment has been minimized.

Copy link

commented Jun 10, 2019

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "sharding-2",
    "component": "gaia",
    "pr-id": "339",
    "commit-sha": "4c2fde7b96c5512e392716f082544efbaff9ccde"
  },
  {
    "project": "sharding-2",
    "component": "backend",
    "pr-id": "424",
    "commit-sha": "73614d296678df89f57458013e3f7b27cf936f19"
  },
  {
    "project": "sharding-2",
    "component": "manipulate",
    "pr-id": "87",
    "commit-sha": "51d3fdf745a83015dc7474700a0b017099f15f47"
  }
]
@aporeto-bot

This comment has been minimized.

Copy link

commented Jun 10, 2019

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "sharding-2",
    "component": "backend",
    "pr-id": "424",
    "commit-sha": "ef6124e9bff083f83630fc2a3045c3779c398781"
  },
  {
    "project": "sharding-2",
    "component": "gaia",
    "pr-id": "339",
    "commit-sha": "cd787f6c683f390ddc221e84b759c170d16fd5bd"
  },
  {
    "project": "sharding-2",
    "component": "manipulate",
    "pr-id": "87",
    "commit-sha": "5763eb6aed028dcdf5e22d3b710cfb2f6348de91"
  }
]
@aporeto-bot

This comment has been minimized.

Copy link

commented Jun 10, 2019

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "sharding-2",
    "component": "gaia",
    "pr-id": "339",
    "commit-sha": "e9ee04072ea0896a678fa28e128d427e08aec698"
  },
  {
    "project": "sharding-2",
    "component": "manipulate",
    "pr-id": "87",
    "commit-sha": "5763eb6aed028dcdf5e22d3b710cfb2f6348de91"
  },
  {
    "project": "sharding-2",
    "component": "backend",
    "pr-id": "424",
    "commit-sha": "ef6124e9bff083f83630fc2a3045c3779c398781"
  }
]
@aporeto-bot

This comment has been minimized.

Copy link

commented Jun 11, 2019

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "sharding-2",
    "component": "gaia",
    "pr-id": "339",
    "commit-sha": "e83576980924a08b9ce4b0838a6675c98f362ffb"
  },
  {
    "project": "sharding-2",
    "component": "manipulate",
    "pr-id": "87",
    "commit-sha": "9253c23a279c0dd77ebe3875fb6adc615300b412"
  },
  {
    "project": "sharding-2",
    "component": "backend",
    "pr-id": "424",
    "commit-sha": "f60bd7c6c2e51ea427f831e118967458928c9556"
  }
]
@aporeto-bot

This comment has been minimized.

Copy link

commented Jun 11, 2019

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "sharding-2",
    "component": "gaia",
    "pr-id": "339",
    "commit-sha": "e83576980924a08b9ce4b0838a6675c98f362ffb"
  },
  {
    "project": "sharding-2",
    "component": "manipulate",
    "pr-id": "87",
    "commit-sha": "8acc4ca811538a6216ee41ea7d626b117b363b09"
  },
  {
    "project": "sharding-2",
    "component": "backend",
    "pr-id": "424",
    "commit-sha": "4d36de4b6ccc457a909a13dcf5dc9a336fdda6e3"
  }
]
// If it returns an error, this error will be returned to the caller
// of the manipulate Operation, but the object that has been
// created will still be created in database.
OnShardedWrite(manipulate.TransactionalManipulator, manipulate.Context, elemental.Operation, elemental.Identifiable) error

This comment has been minimized.

Copy link
@dstiliadis

dstiliadis Jun 11, 2019

Member

That is confusing for me (as an API user). What does it really mean? Shall I retry? Shall I delete? How do I recover if I see this error?

This comment has been minimized.

Copy link
@primalmotion

primalmotion Jun 11, 2019

Author Member

It's more like a hook. I'm still unsure if I should have a Hooker (just for the sake of the name :)) or leave it in the sharder. Errors are returned to manipulator caller

@aporeto-bot

This comment has been minimized.

Copy link

commented Jun 11, 2019

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "sharding-2",
    "component": "gaia",
    "pr-id": "339",
    "commit-sha": "e83576980924a08b9ce4b0838a6675c98f362ffb"
  },
  {
    "project": "sharding-2",
    "component": "manipulate",
    "pr-id": "87",
    "commit-sha": "26ecf1b1bd5945676cd9133b291ab50fca71cf02"
  },
  {
    "project": "sharding-2",
    "component": "backend",
    "pr-id": "424",
    "commit-sha": "2baa2464e1b5293455c175245716412a50ea9f1d"
  }
]
@aporeto-bot

This comment has been minimized.

Copy link

commented Jun 11, 2019

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "sharding-2",
    "component": "backend",
    "pr-id": "424",
    "commit-sha": "6a65c3aaddf1b6376ec8c695eb0c6546c0a626fb"
  },
  {
    "project": "sharding-2",
    "component": "gaia",
    "pr-id": "339",
    "commit-sha": "2fa19804d88eb3b71c14078a27add6f05b62f638"
  },
  {
    "project": "sharding-2",
    "component": "manipulate",
    "pr-id": "87",
    "commit-sha": "26ecf1b1bd5945676cd9133b291ab50fca71cf02"
  }
]

@primalmotion primalmotion merged commit 61c50d9 into master Jun 12, 2019

4 of 6 checks passed

codecov/patch 15.62% of diff hit (target 77.52%)
Details
functional-tests Submitter: reason: . functional-tests set to pending
Details
built
Details
codecov/project 77.32% (-0.2%) compared to 009a99a
Details
functional-tests-trigger Submitter: reason: . functional-tests-trigger set to success
Details
unit-tests
Details

@primalmotion primalmotion deleted the sharding-2 branch Jun 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.