Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the manipulator retries on forbidden/unauthorized #95

Merged
merged 3 commits into from Aug 5, 2019

Conversation

@dstiliadis
Copy link
Member

commented Aug 3, 2019

The retry logic will essentially retry for ever if it is forbidden/unauthorized. It will renew the token and jump to retry that will start everything again.

The change limits the number of retry attempt to a maximum of 2.

@dstiliadis dstiliadis requested a review from primalmotion Aug 3, 2019

@aporeto-dimitri

This comment has been minimized.

Copy link
Contributor

commented Aug 3, 2019

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "",
    "component": "enforcerd",
    "pr-id": "1318",
    "commit-sha": "be350badb6056c994dbbbc75afb833247c25bfc2"
  },
  {
    "project": "",
    "component": "manipulate",
    "pr-id": "95",
    "commit-sha": "9964b40268ff0d630fef2a5e0769462520cb0073"
  }
]
@aporeto-dimitri

This comment has been minimized.

Copy link
Contributor

commented Aug 3, 2019

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "",
    "component": "backend",
    "pr-id": "491",
    "commit-sha": "7a406a5e232c38f798bc0c968f3de1d8f9192a74"
  },
  {
    "project": "",
    "component": "manipulate",
    "pr-id": "95",
    "commit-sha": "9964b40268ff0d630fef2a5e0769462520cb0073"
  }
]
@codecov

This comment has been minimized.

Copy link

commented Aug 3, 2019

Codecov Report

Merging #95 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #95      +/-   ##
==========================================
+ Coverage   76.79%   76.81%   +0.01%     
==========================================
  Files          35       35              
  Lines        2564     2566       +2     
==========================================
+ Hits         1969     1971       +2     
  Misses        517      517              
  Partials       78       78
Impacted Files Coverage Δ
maniphttp/manipulator.go 96.63% <100%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49b18a6...5954aa9. Read the comment docs.

@primalmotion
Copy link
Member

left a comment

Actually the unit test is missing

@aporeto-dimitri

This comment has been minimized.

Copy link
Contributor

commented Aug 4, 2019

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "",
    "component": "backend",
    "pr-id": "491",
    "commit-sha": "ec9fbbdd48aca3b15c25f850f7b5d1c78de64b55"
  },
  {
    "project": "",
    "component": "manipulate",
    "pr-id": "95",
    "commit-sha": "9964b40268ff0d630fef2a5e0769462520cb0073"
  }
]
@aporeto-dimitri

This comment has been minimized.

Copy link
Contributor

commented Aug 4, 2019

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "",
    "component": "backend",
    "pr-id": "491",
    "commit-sha": "7229bb631d3c7f6fdd03f5748c913f4daa1e3b2d"
  },
  {
    "project": "",
    "component": "manipulate",
    "pr-id": "95",
    "commit-sha": "9964b40268ff0d630fef2a5e0769462520cb0073"
  }
]

Added test that shows where it was broken. Without the change, test will timeout.

@aporeto-dimitri

This comment has been minimized.

Copy link
Contributor

commented Aug 4, 2019

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "",
    "component": "backend",
    "pr-id": "491",
    "commit-sha": "7229bb631d3c7f6fdd03f5748c913f4daa1e3b2d"
  },
  {
    "project": "",
    "component": "manipulate",
    "pr-id": "95",
    "commit-sha": "5954aa9ed512e79b0f301f633e8377ec45204be6"
  }
]
@aporeto-dimitri

This comment has been minimized.

Copy link
Contributor

commented Aug 5, 2019

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "",
    "component": "backend",
    "pr-id": "491",
    "commit-sha": "7229bb631d3c7f6fdd03f5748c913f4daa1e3b2d"
  },
  {
    "project": "",
    "component": "manipulate",
    "pr-id": "95",
    "commit-sha": "5954aa9ed512e79b0f301f633e8377ec45204be6"
  }
]
@aporeto-dimitri

This comment has been minimized.

Copy link
Contributor

commented Aug 5, 2019

/build - automatically fired by gogo with following PRs and commit SHAs v1.0.0

[
  {
    "project": "",
    "component": "manipulate",
    "pr-id": "95",
    "commit-sha": "5954aa9ed512e79b0f301f633e8377ec45204be6"
  }
]

@dstiliadis dstiliadis merged commit b8d9765 into master Aug 5, 2019

4 checks passed

built
Details
codecov/patch 100% of diff hit (target 76.79%)
Details
codecov/project 76.81% (+0.01%) compared to 49b18a6
Details
unit-tests
Details

@dstiliadis dstiliadis deleted the fix-retries branch Aug 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.