Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new: use POST for authentify #26

Merged
merged 1 commit into from Sep 7, 2019

Conversation

@primalmotion
Copy link
Member

commented Sep 7, 2019

@primalmotion

This comment has been minimized.

Copy link
Member Author

commented Sep 7, 2019

/build

1 similar comment
@primalmotion

This comment has been minimized.

Copy link
Member Author

commented Sep 7, 2019

/build

@codecov

This comment has been minimized.

Copy link

commented Sep 7, 2019

Codecov Report

Merging #26 into master will decrease coverage by 0.21%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #26      +/-   ##
==========================================
- Coverage   82.99%   82.78%   -0.22%     
==========================================
  Files          11       11              
  Lines         541      546       +5     
==========================================
+ Hits          449      452       +3     
- Misses         73       74       +1     
- Partials       19       20       +1
Impacted Files Coverage Δ
client/client.go 88.5% <66.66%> (-0.51%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01a540e...18af6ec. Read the comment docs.

@primalmotion primalmotion merged commit 170c8e2 into master Sep 7, 2019

3 of 4 checks passed

codecov/patch 66.66% of diff hit (target 82.99%)
Details
built
Details
codecov/project 82.78% (-0.22%) compared to 01a540e
Details
unit-tests
Details

@primalmotion primalmotion deleted the post-authn branch Sep 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.