Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allowing proxy settings from the environment (#30) #32

Merged
merged 1 commit into from Dec 3, 2019

Conversation

@mheese
Copy link
Contributor

mheese commented Nov 30, 2019

Backport for 3.12

@mheese mheese self-assigned this Nov 30, 2019
@codecov

This comment has been minimized.

Copy link

codecov bot commented Nov 30, 2019

Codecov Report

Merging #32 into release-3.12.0 will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@                Coverage Diff                 @@
##           release-3.12.0      #32      +/-   ##
==================================================
+ Coverage            82.9%   82.94%   +0.03%     
==================================================
  Files                  11       11              
  Lines                 550      551       +1     
==================================================
+ Hits                  456      457       +1     
  Misses                 74       74              
  Partials               20       20
Impacted Files Coverage Δ
client/client.go 88.62% <100%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c4a3bb...83c2840. Read the comment docs.

@mheese mheese merged commit e0b7761 into release-3.12.0 Dec 3, 2019
4 checks passed
4 checks passed
codecov/patch 100% of diff hit (target 82.9%)
Details
codecov/project 82.94% (+0.03%) compared to 9c4a3bb
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@mheese mheese deleted the fix-proxy-settings-3-12 branch Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.